Zondax / ledger-tezos

Apache License 2.0
8 stars 5 forks source link

Display entrypoint #167

Open ghost opened 3 years ago

ghost commented 3 years ago

Currently when displaying a Transfer operation with the presence of an "entrypoint" the name of said entrypoint is not displayed, but only a hash of the parameters raw data is what is shown on screen, similar to "no parameters...".

It would be a definite UX upgrade if we could display said entrypoint, considering we have some known and predefined entrypoints, aswell as custom entrypoint which are UTF-8 encoded, so we could (at least partially) display custom entrypoint names too. This could also lead to a tangible security improvement were a malicious entrypoint was called instead

See https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/rust/app/src/parser/operations/transfer.rs#L249 https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/rust/app/src/parser/operations/transfer.rs#L331

:link: zboto Link