search

ZoneMinder / zmNinja

High performance, cross platform ionic app for Home/Commerical Security Surveillance using ZoneMinder
http://zmninja.zoneminder.com
Other
1.02k stars 271 forks source link

New language: German #466

Closed pliablepixels closed 7 years ago

pliablepixels commented 7 years ago

Credit @florie1706

465

pliablepixels commented 7 years ago

@florie1706 - its easiest for you to test on a desktop version - which desktop version do you use ? I can send you a test version

florie1706 commented 7 years ago

@pliablepixels - I always use your zmNinja-win64bit on a Windows 10 machine

pliablepixels commented 7 years ago

here you go https://drive.google.com/file/d/0B3iQz0D8vxltYjFpdmVGbkVOems/view?usp=sharing

florie1706 commented 7 years ago

Any chance to have a test build with my current lang file? Wasn't able to test the new language file yet. Otherwise I will wait for your next official release :)

pliablepixels commented 7 years ago

sure - BTW, forgot to respond to one of your questions - I'd prefer you don't put in zmNinja inside your language files. I append the app name as the last word in code (this is because the app name is configurable). You've encoded the app name in two strings

https://github.com/pliablepixels/zmNinja/blob/master/www/lang/locale-de.json#L345 (in this instance I add the app name at the end of the string. I don't have a way to have the app name inserted mid-string as you requested)

https://github.com/pliablepixels/zmNinja/blob/master/www/lang/locale-de.json#L391

Can you please remove those ?

pliablepixels commented 7 years ago

I'll be making a new release soon - can you please update the latest key ? I added an extra key for HTTP timeouts