ZoneMinder / zmNinja

High performance, cross platform ionic app for Home/Commerical Security Surveillance using ZoneMinder
http://zmninja.zoneminder.com
Other
1.01k stars 268 forks source link

1.4.3 encode URL seems broken at least on iOS (Event/24 hr filters etc) #933

Closed pliablepixels closed 4 years ago

pliablepixels commented 4 years ago

@fri-K the changes for encode broke other scenarios - I had to revert to the old code, but with spaces removed. Can you pull master and see if you are facing double encode issues when building #920

fri-K commented 4 years ago

@pliablepixels Hi, current master is not working for me:

May 19, 2020 07:23:28 PM DEBUG Monitor URL to fetch is:https://example.com/api/monitors/index/Type !=:WebSite.json?&token=<removed>
May 19, 2020 07:23:28 PM DEBUG CACHE: NOT found for:cached_monitors reverting to HTTP
May 19, 2020 07:23:28 PM DEBUG ***  Inside native HTTP error for url:{"status":500,"url":"https://example.com/api/monitors/index/Type%2520!=:WebSite.json?&token=<removed>
May 19, 2020 07:23:28 PM INFO CACHE: error with http get {"status":500,"url":"https://example.com/api/monitors/index/Type%2520!=:WebSite.json?&token=<removed>
May 19, 2020 07:23:28 PM ERROR Monitor load failed {"status":500,"url":"https://example.com/api/monitors/index/Type%2520!=:WebSite.json?&token=<removed>

Sorry for late response but with previous zmNinja master I couldn't even start an app on any of my devices and I couldn't find time to make proper problem analysis. As of today, app is starting, but there is still some space character before != I spotted also that now ninja is automatically changing spaces in ZM url to %20

pliablepixels commented 4 years ago

Yup I had to redo all the changes - it broke with a previous CakePHP version. What happens if you enable "Don't encode URLs" in dev settings?

fri-K commented 4 years ago

"Don't encode URLs" in dev settings solves my problem again. Solution is fine for me, thanks :)