ZoneMinder / zmeventnotification

Machine Learning powered Secure Websocket & MQTT based ZoneMinder event notification server
412 stars 128 forks source link

Don't crash when old-style passwords are still in use. #326

Closed mludvig closed 3 years ago

mludvig commented 3 years ago

Fix for #325

Report an error and suggest a solution instead of crashing when old-style passwords are still in use for event server users.

This is the new error log:

CONSOLE DBG-2:2020-10-23,10:04:05 PARENT: ---------->onConnect msg START<--------------
CONSOLE ERR:2020-10-23,10:04:05 PARENT: Old-style password set for user 'admin'. Change it through the ZM console and try again.
10/23/20 10:04:05.244100 zmeventnotification[16430].ERR [main:988] [PARENT: Old-style password set for user 'admin'. Change it through the ZM console and try again.]
CONSOLE DBG-1:2020-10-23,10:04:05 PARENT: marking for deletion - bad authentication provided by ::ffff:210.54.xx.xx
CONSOLE DBG-2:2020-10-23,10:04:05 PARENT: ---------->onConnect msg STOP<--------------
pliablepixels commented 3 years ago

Thanks for the PR. I actually already committed code for this https://github.com/pliablepixels/zmeventnotification/commit/38729d8fcc29224da6bb2eb0d9893e472cbf4cb9

mludvig commented 3 years ago

Heh, ok, too late then ;)