search

ZoneMinder / zmeventnotification

Machine Learning powered Secure Websocket & MQTT based ZoneMinder event notification server
408 stars 128 forks source link

Neo for consideration #413

Closed baudneo closed 2 years ago

baudneo commented 2 years ago

I will start working on docs.

connortechnology commented 2 years ago

Coupla comments:

First off this is a lot of work and I like a lot of what I see, but I don't see just merging this PR as is. Would much prefer it broken into smaller bits. Second: Please don't remove all history prior to 7.0.0. Or let's discuss about that. Because we at ZM don't bother with changelogs, because that is what commit comments are for. So maybe it's ok. Anyone else have thoughts? Third, references to github should reference the ZoneMinder repo, not yours once merged. Perhaps reference all three.

I will likely cherry pick a lot of stuff out of zmeventnotification.pl to help reduce the patch size and there are obvious fixes in there.

We will get this merged, but it is going to take some effort.

baudneo commented 2 years ago

Agreed, I will reimplement the docs from source and add-on for the new components and features. Current doc's are more geared towards the neo repos. I will start cleaning it up and working on getting it up to snuff.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.