Release v1.27.0 [$100 awarded]

[kylejohnson]

Creating an issue to track any bugs or issues or whatnot we run into. Lets make this a clean release!

Tests

• [x] I can stream and modect a libvlc monitor
• [x] The Ubuntu package requirements for libvlc monitors are documented
• [x] The CentOS package requirements for libvlc monitors are documented
• [x] The flat skin displays properly
• [ ] The purgewhenfull filter is enabled by default
• [x] Dockerfile has initial documentation

  Documentation

• [x] Wiki – Update Wiki documentation to reflect any changes to existing features
• [ ] Local – Update internal documentation to reflect any changes to existing features
• [ ] Wiki – Add new documentation to Wiki for any new features
• [ ] Local – Add new internal documentation for any new features

  Distro

These tests were performed on the following Linux distributions:

• [x] Ubuntu LTS
• [ ] Ubuntu
• [x] CentOS/Redhat
• [x] Fedora
• [ ] Other

  Browser

These tests where performed using recent versions of the following browsers:

• [x] FireFox
• [ ] Chromium
• [ ] Chrome
• [ ] Internet Explorer
• [ ] Safari
• [ ] Mobile (state browser)
• [ ] Other

  Startup

• [x] Verify initscript can auto-start ZoneMinder during the boot process
• [x] Verify initscript can manually stop, start, and restart ZoneMinder

  Filters

• [x] Verify a filter can be manually executed
• [x] Verify a background filter runs automatically

  Authentication

• [x] None - Trivial
• [ ] Plain – Set authentication to plain and verify
• [x] Hashed – Set authentication to hashed and verify
• [ ] Remote – Set authentication to remote and verify

  Streaming Methods

• [ ] Local – Verify successful stream from this camera type
• [x] Http – Verify successful stream from this camera type
• [x] Ffmpeg – Verify successful stream from this camera type
• [x] Libcurl – Verify successful stream from this camera type
• [x] Libvlc – Verify successful stream from this camera type

  Recording Functions

• [x] Monitor - Verify this function works
• [x] Modect - Verify this function works
• [x] Record - Verify this function works
• [ ] Mocord - Verify this function works
• [ ] Nodect - Verify this function works

  PTZ Control

• [x] Verify ptz control works

  Skins

• [x] Classic – verify field alignments
• [x] Flat – verify field alignments

  Log Files

• [x] Inspect log files for anything unusual

  Upgrade

• [x] zmupdate - Verify an upgrade for a recent minor release
• [x] zmupdate – Verify an upgrade for a past major release

  Optional Features

• [ ] X10 - verify basic communication with an x10 device
• [ ] E-mail – verify events are sent through e-mail
• [ ] Upload – verify events are uploaded
• [ ] eyeZm – verify this works
• [x] Cambozola – verify from Internet Explorer

The $100 bounty on this issue has been claimed at Bountysource.

[knight-of-ni]

Reminder to self to merge the zmcamtool branch before we release

UPDATE: This step has been completed.

[knight-of-ni]

Just made the following observations: 1) For some reason I have to click the Login button twice to actually login. The first click appears to just reload the login screen. 2) PTZ Controls do not appear after clicking "control" in the monitor. Instead, nothing is shown where the controls used to reside.

I have not yet seen an error messages generated by these issues. Will continue to investigate.

Something we may want to consider for 1.27, but will certainly have to address at some point in the future: PTZ controls are currently hard coded to a single method. Take a camera using the ffmpeg method and its associated ptz control for example. The ptz control will not appear as a selectable option if the method is changed to libvlc.

We need the ability to have a single ptz control be selectable for more than a single method.

UPDATE: Item number 2 above was caused by the PTZ control type being reset back to NULL. I need to try again to verify if this will happen every time or was a result of me screwing around with the database.

[knight-of-ni]

@kylejohnson I didn't realize we never merged @nagyrobi 's translation work. Can we re-open and merge all the translation pull requests referenced in issue #72 for the 1.27 release? I'm not sure what should be done to accomplish this.

[kylejohnson]

Hey @knnniggett, unfortunately I wasn't able to get his work merged - nor am I sure how to at this point.

His work was done off of the 'develop' branch, when we had it. After @mastertheknife merged develop into master and then closed it, that kind of screwed us up.

Also the way that nagy did his work - a bunch of pull requests instead of a single one - makes it even more difficult.

At this point I'm not sure how to get his work merged. :(

@nagyrobi - do you still have the translation changes on your own box?

[nagyrobi]

Yes I do. I'm currently using the box with v1.25.0 and my changes without any issues.

[kylejohnson]

Just tested the libvlc source type with a URL that works perfectly in VLC and I get the following errors in the log file.

[knight-of-ni]

User column should have been added when you ran zmupdate.pl. See: https://github.com/ZoneMinder/ZoneMinder/blob/master/db/zm_update-1.27.0.sql

Wait, I think I know what the problem is. Before you build zoneminder, manually bump configure.ac, cmakelist.txt, and version.txt to "1.27". If you don't the system will think is is "1.26.x" and never run the 1.27 patch.

[kylejohnson]

I've pushed branch release-1.27 to github as our 1.27 release branch. This way 1.27 is feature-frozen and no new bugs can be introduced.

[kylejohnson]

@knnniggett - I'll try that shortly.

[kylejohnson]

Commit 9d3117a428be0f0afda81401992cf5ac90204671

[knight-of-ni]

I've built zoneminder 1.27 successfully on both CentOS 6 and Fedora 19 using cmake and in both cases, I have to click the login button twice to actually login. No error messages are presented or logged in zoneminder. Can you test this on one of your Ubuntu vm's?

[newburns]

I can test it if you give me some build instructions. I have 3 zoneminders in production, and I have a pretty substantial testing environment with Proxmox.

[knight-of-ni]

@newburns

git clone -b release-1.27 https://github.com/ZoneMinder/ZoneMinder.git
cd ZoneMinder

Then build as you normally would.

[kylejohnson]

Big testing points for this release are:

1. curl source type
2. libvlc source type
3. new skin (?skin=flat)

[knight-of-ni]

@kylejohnson I'm sure this is likely some kind of user error, but I stared at a blinking cursor for about 6 hours and ran our of time yesterday after issuing this command:

sudo docker pull ubuntu:precise

I'll chat with you tomorrow about it.

[knight-of-ni]

Well, I found out the problem. There is a package in the Ubuntnu repo called docker, but it is something entirely different!

So don't do this to install the docker we need:

sudo apt-get install docker

Instead, go here: https://docs.docker.io/en/latest/installation/ubuntulinux/

Follow the instructions to add the docker repo and then do this:

sudo apt-get install lxc-docker

[knight-of-ni]

UPDATE: I have determined that #296 is causing one to click the Login button twice before the system acually logs you in. Since #296 was implemented to fix another problem, we must try and determine a solution that fixes both issues.

[knight-of-ni]

I have applied a temporary solution to ptz control types only being available for a single monitor source type (e.g. ptz control types for ffmpeg cameras would not be available if the libvlc method was chosen instead): https://github.com/ZoneMinder/ZoneMinder/commit/d20e0ee2e7c66e4a1baab86b747851eb431f48d1

I have punted on a better solution due to time constraints. For a future version of zoneminder, I would like to redefine ptz control types to be just these two types: serial and ip. These are really the only two kinds of ptz controls I can think of. Ptz commands are always either sent out over a serial port or over an ethernet cable.

[knight-of-ni]

I believe I have fixed the issue with having to press the login button twice via this commit 26be1bd . Please test. For the moment, this resolves all the issues that I am aware of. Planning to build a new 1.27 rpm and re-test one more time.

[knight-of-ni]

pull request #333 needs review

[kylejohnson]

@knnniggett commit c3200dfec792c9b01a67a2b4a99c98fe15c72812 doesn't appear to make the filter run by default - at least by looking at it from the webui, there is no * next to the filter name.

[kylejohnson]

Just about ready to release this. The libvlc source type works great, and the flat skin looks better with the few fixes I pushed up. Anything else that we should test before releasing?

I want to create a wiki page which has a checkbox list - similar to what I have above in the initial comment - of items which we should check for each and every release. Let's start thinking about what to add in that list.

[knight-of-ni]

@kylejohnson That's odd. The "*" appeared when I tested it on my system. I'll check again today.

[knight-of-ni]

I made a template for the list below in the wiki: https://github.com/ZoneMinder/ZoneMinder/wiki/How-to-test-a-release-%5Btemplate%5D

@kylejohnson feel free to move it if there is a better spot for it.

The template is intended to be pasted into an issue and should automatically format into a list of check-boxes like so:

[knight-of-ni]

@kylejohnson After git pull'ing the latest changes from the 1.27 release branch, I performed another build of zoneminder 1.27 on CentOS 6 and Fedora 19. In each case, after creating a new database, I navigated to the filters screen and noted that the PurgeWhenFull filter had a "*" after it and "[background]" appeared next to it after I selected it from the list.

Can you double check on your end that your test was against a new database that had commit c3200df ?

[kylejohnson]

As of commit 75d390d70aff164f9afdeead6f5a344c8063e8ae Version 1.27.0 is released.