search

ZoneMinder / zoneminder

ZoneMinder is a free, open source Closed-circuit television software application developed for Linux which supports IP, USB and Analog cameras.
http://www.zoneminder.com/
GNU General Public License v2.0
4.9k stars 1.2k forks source link

Feat: Ability to download videos on Event view page with a multiport configuration #3920

Closed IgorA100 closed 2 months ago

IgorA100 commented 2 months ago

If the port is different from 80, the browser will start watching the video instead of downloading.

Close https://forums.zoneminder.com/viewtopic.php?t=33167

connortechnology commented 2 months ago

This does nothing for me here. Yes it removes the port but the behaviour is the same. Could be because mine is a multi-server setup and the url points to another host entirely.

IgorA100 commented 2 months ago

Could be because mine is a multi-server setup and the url points to another host entirely.

Probably yes, I have no way to check the work on a multi-server system. But if there is only one server and many ports, then without this change the browser tries to play the video instead of downloading it, which naturally leads to an error. Since this change did not break your system, I think this PR can be approved.

IgorA100 commented 2 months ago

@connortechnology What confuses you about this PR?