ZoneMinder / zoneminder

ZoneMinder is a free, open source Closed-circuit television software application developed for Linux which supports IP, USB and Analog cameras.
http://www.zoneminder.com/
GNU General Public License v2.0
4.92k stars 1.2k forks source link

Zms/videostream improvements #404

Closed Sune1337 closed 9 years ago

Sune1337 commented 10 years ago

Support streaming with zms (using ffmpeg) better …

* ZoneMinder compiles with ffmpeg 0.5..master
* Make VideoStream class able to stream through ffmpeg better.
* Ability to use fixed quality instead of fixed bitrate (by specifying bitrate 0...100)
* Format url parameter supports <format>/<encoder> syntax

See commit message for details.

knight-of-ni commented 9 years ago

Sometimes learning the hard way is a good way to learn. I've made many github mistakes and have learned from it. honestly, I have learned to really like github.
As far as I know the only way to resolve the issue is to either close that open pull request or merge it... but I think we are going to hold that off until after 1.28.0 is released

Sune1337 commented 9 years ago

the commit messages for easy reviwing:

6e77632

4b47336

df4a9f2

0555068

knight-of-ni commented 9 years ago

@connortechnology is building it now. Sounds like it worked. He is just going to merge the changes directly into master.

Sune1337 commented 9 years ago

sounds great

Sune1337 commented 9 years ago

I checked out the commits; the commit "bugfix; coredump if no codec name was specified in url. " is missing from the master branch. Its not really related to compilation issues; just a bugfix i sneaked in there :) just wanted to point it out.

connortechnology commented 9 years ago

I've got it now. Now sure how I missed it. Thanks for your efforts on these.

knight-of-ni commented 9 years ago

Just confirmed that master (still) builds fine on Fedora & CentOS using ffmpeg. Also built Fedora with the NO_FFMPEG flag. We are green.

Sune1337 commented 9 years ago

i wish i had champagne