feat: replace `trim` by the #1 most popular trim library - Githubissues

ZooTools / email-spell-checker

📮 An ultratiny (1.9 KB) and fast JavaScript email checker to reduce users typing a wrong email. Written in TypeScript. Enterprise-grade.

https://zootools.co/tools/email-spell-checker

MIT License

164 stars 11 forks source link

feat: replace `trim` by the #1 most popular trim library #5

Closed ferreiro closed 2 years ago

ferreiro commented 2 years ago

Description of change

We inherit a trim function from mailcheck (an outdated library that we rewrote in TypeScript).

It doesn't make sense to use it versus trim a well tested and #1 trim library in NPM ecosystem right now with 5M weekly downloads.

In order to not create external dependencies, I copy paste their trim function.

Pull-Request Checklist

[x] Code is up-to-date with the main branch
[x] npm run lint passes with this change
[x] npm run test passes with this change
[x] This pull request links relevant issues as Fixes #0000
[x] There are new or updated unit tests validating the change
[x] Documentation has been updated to reflect this change
[x] The new commits follow conventions outlined in the conventional commit spec