search

Zookal / HarrisStreet-ImpEx

Magento n98-magerun module for importing and exporting configuration data. Import supports hierarchical folder structure and of course different environments.
62 stars 14 forks source link

Validate Scope and ScopeId before updating core_config_data #4

Closed mwr closed 9 years ago

mwr commented 9 years ago

to prevent the creation of incorrect database entries we should validate whether a scope-scopeId combination is valid. Otherwise you may have strange side-effects and database entries.

SchumacherFM commented 9 years ago

Matthias, thank you very much for this high value contribution. This feature adds a real gem to the project! 👏

I left a few notes for fixing. If you think you're finished please make an interactive rebase and merge all commits into one and do then a git push force. Squash all commits into one. Thank you!

mwr commented 9 years ago

Made the changes to comparison operator usage and added pre loading of websites and stores. Also squashed all commits into one commit.

SchumacherFM commented 9 years ago

👏 thank you!