search

Zookal / magento-mock

Transparent auto detecting of disabled core modules and providing mock objects for not breaking Magento.
46 stars 13 forks source link

remove Mage_GoogleCheckout special function #8

Closed heldchen closed 9 years ago

heldchen commented 9 years ago

Mage_Sales does not have a dependency on Mage_GoogleCheckout anymore, at least not since 1.9.0.0, possibly earlier.

the workaround used has some side effects for extensions that make use of Mage::helper('sales')->getPaymentMethods(), as magento-mock only ads the code, "active" and "model". in our case, the (disabled) payment method was included in the configuration setting with <source_model>adminhtml/system_config_source_payment_allmethods</source_model> - as the title is not shown, it's listed at the top with an empty entry missleading the user.

SchumacherFM commented 9 years ago

Thank you for your contribution!

What are the other shops doing which have Magento < 1.9 installed? Can you please describe your solution for that condition?

heldchen commented 9 years ago

fair enough. i'll create a new push request.