search

ZoomApps / Liveapp

Liveapp Framework :rocket:
https://www.liveapp.com.au
2 stars 1 forks source link

filter toolbar field name clearing #44

Closed JasonBev closed 6 years ago

JasonBev commented 6 years ago

Follow up to #40 Minor usability issue - The same flow fields have an issue when you individually clear their value (as opposed to clear all) - the field name will be removed from the dropdown instead of remaining in view.

Liveware temp fix- line 101 - FilterToolbar.js m_filterFields.val(pagefield.Name); to m_filterFields.val(filter.Name);

It will still remove the value in line 90/91 as it's looking for the value with FF$ removed but re-populates it with that fix. A cleaner solution would probably need to be applied as a permanent fix for liveapp.

paulfisher53 commented 6 years ago

I have applied your fix to lines 91 and 101. I think all functionality is now working for filtering flowfields.

Can you please load this fix and confirm? Fix-44.zip

JasonBev commented 6 years ago

File upload incomplete on comment, please add again/provide link.

paulfisher53 commented 6 years ago

Sorry about that, updated...

JasonBev commented 6 years ago

Fix working, I think we have it all resolved now.

paulfisher53 commented 6 years ago

Thanks