search

ZoomApps / Liveapp

Liveapp Framework :rocket:
https://www.liveapp.com.au
2 stars 1 forks source link

Convert NewColumnOrder function to Mobile #7

Closed JasonBev closed 7 years ago

JasonBev commented 7 years ago

For use in client plan line sorting for mobile view

paulfisher53 commented 7 years ago

Done. Please merge this Fix.zip

paulfisher53 commented 7 years ago

Found an issue where the mobile function is not taking into account the row selector.

paulfisher53 commented 7 years ago

Here's the new fix that takes into account the row selector SortFix.zip

paulfisher53 commented 7 years ago

I still get the same issue with the new fix.

e.g In screenshot below the value will have the 13 (left image). When i=1 it’s looking for the item number 12 which doesn’t exist in m_cols (right image) so it still pushes the undefined object to new_cols and new_colNames. Rather than skipping 0 and starting at 1 I need to remove the last value of the array before existing sort passes it in I guess.

image

paulfisher53 commented 7 years ago

Closed, check https://github.com/LiveappSolutions/Liveapp/commit/af1c1cc05a95081aaa29f6583a1e250cd43a54f8 for the fix