search

ZoopOTheGoop / ffxiv-crafting-solver

A lot of abstract math done on reinforcement learning just to solve crafting in a video game
Other
0 stars 0 forks source link

Use codegen to pull in the datamined tables #2

Closed ZoopOTheGoop closed 1 year ago

ZoopOTheGoop commented 2 years ago

For static tables we can generate our lookups from the data files. This is a little fragile in that sometimes FFXIV changes the format a bit, but it would be better for it to crash and let me know, than to be using outdated stuff and have to find it again.

I don't think this should be at compile-time or via build.rs, we should probably just gen the files and commit. I'm not sure if we should submod ffxiv-datamining, or just make a tool that gets pointed to the directory. I don't like git submodules much, but this is an area where it's arguably better than the alternative since it keeps things in sync without me manually vendoring the files. The reason I don't want to do it at compile/build time is due to this - we'd have to vendor the files or require manual submodule updating to even build the project. We could download the files in build.rs but that seems... ill advised and excessive.

Things we should generate

In the future we may want to gen Recipe.csv and the things it references (like Item.csv) to more easily be able to generate recipes for testing and (eventually) simulation.

ZoopOTheGoop commented 2 years ago

Removed from milestone, this is a very minor QOL thing, this seemed more pressing when there were a lot more tables but the formulas seem to have simplified quite a lot.