search

Zooz / predator

A powerful open-source platform for load testing APIs.
https://zooz.github.io/predator/
Apache License 2.0
576 stars 109 forks source link

Tests without http:// or https:// fails to fire requests #461

Closed enudler closed 4 years ago

enudler commented 4 years ago

Describe the bug When a step URL doesn't start with the protocol, the predator-runner will fail to send the request

To Reproduce Steps to reproduce the behavior:

  1. Open UI
  2. Create a new test
  3. In the URLs (base URL + step URL) (see screenshot) add address without https:// or http://
  4. Run the test
  5. The request won't be successful

Expected behavior Impossible to save test where the URL doesn't contain protocol, The field should be in red with the correct comment Screenshots Current behavior:

Screen Shot 2020-10-07 at 16 48 00

Version:

Additional context A bonus to this issue is to add validation on the backend.

tombrowndev commented 4 years ago

@enudler I can work on this!

enudler commented 4 years ago

Hi @tombrowndev that would be great! We are available on our Slack workspace if you have any questions feel free!

enudler commented 4 years ago

hi @tombrowndev, Please LMK if you are still on this one, we will be glad to assist

tombrowndev commented 4 years ago

Hi @enudler

Many apologies but I'm not going to be able to complete this

anusha5695 commented 4 years ago

@enudler Can pick this too. Would you assign this to me?

enudler commented 4 years ago

Thanks, @anusha5695 assigned

anusha5695 commented 4 years ago

Thanks @enudler. Have also raised the other PR for corrupted test data

anusha5695 commented 4 years ago

Hi @enudler, if protocol is not present both baseurl and url fields should be shown as error fields right?

enudler commented 4 years ago

Hi, yes

On Sat, 24 Oct 2020 at 10:01 anusha5695 notifications@github.com wrote:

Hi @enudler https://github.com/enudler, if protocol is not present both baseurl and url fields should be shown as error fields right?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Zooz/predator/issues/461#issuecomment-715825542, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXVP7ZVIYYHNICOOMSWPILSMJ3V3ANCNFSM4SHNUP2Q .

anusha5695 commented 4 years ago

Thanks @enudler ! Have raised the PR :) Please have a look

One callout - this pr might have conflicts with the other PR cuz both are individual branches. let me know if one of them is merged, i ll fix the other one's conflict