search

Zooz / predator

A powerful open-source platform for load testing APIs.
https://zooz.github.io/predator/
Apache License 2.0
574 stars 109 forks source link

fix(ui): allow specify-name-for-compare-reports #553

Closed cykim0225 closed 2 months ago

cykim0225 commented 3 years ago
Question Answer
Bug fix ✔/✖
New feature ✔/✖

Related issues: #XXX , #XXX ... Closes #XXX , #XXX ...

Further information:

Screen Shot 2021-01-04 at 12 55 28 AM
enudler commented 3 years ago

thanks @cykim0225 @manorlh will review it

cykim0225 commented 3 years ago

Thanks!! I did not add the bonus part btw

manorlh commented 3 years ago

thank you for your contribution it's awesome!

manorlh commented 3 years ago

@cykim0225 @enudler
what do you say guys about adding an underscore and paint the name to blue so the user would understand that he can change the name?

cykim0225 commented 3 years ago

@manorlh I like that idea of painting it blue

cykim0225 commented 3 years ago

@manorlh Thanks for your comments!! I will work on those.

manorlh commented 3 years ago

@cykim0225 thank you!!

cykim0225 commented 3 years ago

@manorlh I've made some change. Could you PR again whenever you're free? Thanks!

manorlh commented 3 years ago

@cykim0225 I will review it soon, thanks!

cykim0225 commented 3 years ago

Thanks for your feedback! :)