ZoroarkDarkrai / pe

0 stars 0 forks source link

This diagram should be resized #13

Open ZoroarkDarkrai opened 3 years ago

ZoroarkDarkrai commented 3 years ago

Screenshot from 2020-11-13 17-32-10.png

This diagram takes almost the whole page. Notice that the text size in the diagram is much bigger than the one in the DG. Hence, it would be better for it to be resized.

nus-se-bot commented 3 years ago

Team's Response

The severity of this issue is VeryLow, as this is purely cosmetic.

Furthermore, it is intended for this diagram to take up the whole page, such that it acts as a clean page break to move the DG on to the next section. If the diagram were to be smaller, the next section may appear and get cut in half, worsening the entire experience for the user and causing confusion.

This was a design consideration that our team decided on and not a bug, and felt that it is best for this diagram to be big so that users can read it more easily.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Screenshot from 2020-11-18 16-03-48.png

The screenshot is from the official CS2103 website.

it is best for this diagram to be big

The developer has agreed that font in the diagram is particularly big compared to the one in the DG. Hence, it's a bug.

Furthermore, it is intended for this diagram to take up the whole page, such that it acts as a clean page break to move the DG on to the next section. If the diagram were to be smaller, the next section may appear and get cut in half, worsening the entire experience for the user and causing confusion.

I do not accept this reason as there're other ways to introuduce a page break and I believe making a diagram particularly big just to create a page break is a bad idea. A simple Google search will lead you to: <div style="page-break-after: always"></div> for adding page breaks.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: This is not a purely cosmestic problem. The user should be able to read the other texts of the DG just fine. Hence, they should be able to read diagrams with similar font size. Making the diagram needlessly large unconvinence the user. They now have to scroll more to read the DG.

Screenshot from 2020-11-18 16-03-48.png

The screenshot is from the official CS2103 website.

I believe this quite important as it's mentioned explicitly in the list of tips to make a good DG.