Previously the python binding consistency tests were resetting the return status to 0 if the python tests pass even if the catch unit tests had failed.
This was masking this failing unit test on Mac, Linux, and Windows.
-------------------------------------------------------------------------------
Buffer format parsing
errors
-------------------------------------------------------------------------------
../../qrenderdoc/Code/BufferFormatter.cpp:5353
...............................................................................
../../qrenderdoc/Code/BufferFormatter.cpp:5859: FAILED:
CHECK( parsed.errors[err.line].contains(err.error, Qt::CaseInsensitive) )
with expansion:
false
Looks like this commit 9bde5324b6ac89d473e04269c98b521d9f48ca7d changed the reported error message from
Invalid enum base type '%1', must be an unsigned integer type.
to
Invalid enum base type '%1', must be an integer type.
and the test was expecting the error message to contain unsigned integer
Changed the expected error message to contain integer type to make the test pass.
Link showing the test failing before the code fix for the test
Zorro666
commented
2 years ago
Description
Do not clear catch failure return state.
Previously the python binding consistency tests were resetting the return status to 0 if the python tests pass even if the catch unit tests had failed.
This was masking this failing unit test on Mac, Linux, and Windows.
Looks like this commit 9bde5324b6ac89d473e04269c98b521d9f48ca7d changed the reported error message from
Invalid enum base type '%1', must be an unsigned integer type.toInvalid enum base type '%1', must be an integer type.and the test was expecting the error message to contain
unsigned integerChanged the expected error message to contain
integer typeto make the test pass.Link showing the test failing before the code fix for the test