When loading a layout close any orphaned windows

[Zorro666]

Description

Issue

1. Default Layout (or any layout) : contains multiple windows but does not contain a specific window ie. Pipeline State
2. Layout 1 contains windows which are not in the Default Layout i.e. Pipeline State window
3. Load Default Layout
4. Load Layout 1
5. Load Default Layout
6. Now unable to open the Pipeline State window because it has become orphaned (no parent) from any tool window manager. Have to restart RenderDoc to be able to open the orphaned windows.

Discussion

• Another solution to the problem would be to pass a valid default tool area to the raiseToolWindow similar to how it is done for addToolWindow and use the default tool area if the window has become orphaned.
  • this would required touching all calls to raiseToolWindow (approximately 45 instances)
  • The orphaned windows will still be in m_ToolWindows so anything iterating over that container and sending events could be sending events to ToolWindows which are not visible.
  • Orphaned windows will not close using closeToolWindow API which might lead to invalid ToolWindow's i.e. ToolWindow's referencing a capture that has been closed but the ToolWindow itself became orphaned
  • The extra logging will help to identify if the scenario is happening

Extra Changes

• Added more logging to help diagnose window manager warnings.
• Added logging for when layouts are saved and loaded to help understand how often that happens when looking at log files from users.

Testing

Following steps mentioned end up with logs like this and are able to open windows which without the fix had not been able to open.

QTRD 224632: [15:24:21]       MainWindow.cpp(3075) - Log     - SaveLayout  0
QTRD 224632: [15:24:25]       MainWindow.cpp(3091) - Log     - LoadLayout  1
QTRD 224632: [15:24:25] ToolWindowManager.cpp(1555) - Warning - area parameter ignored for this type
QTRD 224632: [15:24:25]       MainWindow.cpp(3111) - Log     - Manually closing orphaned window  "capDialog"
QTRD 224632: [15:24:30]       MainWindow.cpp(3091) - Log     - LoadLayout  0
QTRD 224632: [15:24:30] ToolWindowManager.cpp( 879) - Warning - invalid splitter encountered
QTRD 224632: [15:24:30]       MainWindow.cpp(3111) - Log     - Manually closing orphaned window  "meshPreview"
QTRD 224632: [15:24:30]       MainWindow.cpp(3111) - Log     - Manually closing orphaned window  "textureViewer"

[Zorro666]

https://github.com/baldurk/renderdoc/pull/3115