Zorthmaster / pynsource

Automatically exported from code.google.com/p/pynsource
0 stars 0 forks source link

Deep Layout Thread crashes on Mac and Linux #28

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Load a graph
2. Hit 'B' for deep layout
3. After layout we get exception / crash

What is the expected output? What do you see instead?

Expect no exception and a clean exit out of the dialog box.

Original issue reported on code.google.com by abu...@gmail.com on 26 Aug 2012 at 8:08

GoogleCodeExporter commented 9 years ago
After debugging under Linux, it seems that its caused by our calling 
stateofthenation from within the thread.  Fair enough - you are not supposed to 
access the wx gui objects from within the thread.  

I was updating the progress bar etc. correctly via messages but forgot about 
the stateofthenation calls inside class LayoutBlackboard (many calls in here), 
GraphLayoutSpring.layout(), and GraphSnapshotMgr.RestoreGraph().

Original comment by abu...@gmail.com on 26 Aug 2012 at 8:13

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r538.

blackboard - stopped calls to stateofthenation from inside worked thread.
Removed old unused blackboard code.

Original comment by abu...@gmail.com on 26 Aug 2012 at 11:23

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r539.

linux - added wx.CallAfter commands so that blackboard layout status window 
updates correctly.

Original comment by abu...@gmail.com on 26 Aug 2012 at 12:01

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r540.

blackboard - split frame and thread into separate modules.  Correct progress 
bar off by one error.

Original comment by abu...@gmail.com on 26 Aug 2012 at 12:44

GoogleCodeExporter commented 9 years ago
Fixed - at least under Linux.

Original comment by abu...@gmail.com on 26 Aug 2012 at 12:57