Zren / ResizeYoutubePlayerToWindowSize

Userscript: Moves the YouTube video to the top of the website and fill the window with the video player.
160 stars 13 forks source link

Thumbnails stopped appearing #41

Closed iPaulis closed 6 years ago

iPaulis commented 6 years ago

Browser Name: Firefox

Browser Version: 59.0.3 (64-bit) and 61.0.2 (64-bit)

Operating System: Windows 10 (64-bit) and Linux Mint 18.3 (64-bit)

Software Version: 118

Problem Description: I use the Iridium plugin and also this userscript. Everything was working fine until about 2 weeks ago, when the thumbnails stopped showing up after loading a video with autoplay disabled. I don't know why, but for some reason both scripts are not interacting properly with each other. When I disable the Resize script, then Iridium loads the thumbnail correctly, but when I activate this script too, the background goes black.

Steps to reproduce:

1. Have both Iridium (v0.2.1) and Resize YT To Window Size (v118 from GreasyFork and Greasemonkey v4.6) installed.
2. Disable autoplay in Iridium.
3. Load any youtube video and the thumbnail wont show up, just a black background instead.

Let me know if there is any other info I could provide. Thank you in advance.

Zren commented 6 years ago

Which thumbnails?

The sidebar thumbnails are showing up for me.

It's possible were using different "versions" of YouTube though.

What's your VISITOR_INFO1_LIVE and PREF cookie?

Right Click webpage > Inspect Element > Storage > ...

Zren commented 6 years ago

Do you mean the "large thumbnail" for the current video which is showing up as a black rectangle in my firefox screenshot?

Zren commented 6 years ago

Looks like .ytp-cued-thumbnail-overlay needs a z-index: 10.

And the .player-theater-container also needs to override the following CSS rule so that it doesn't show a white box when the video player moves to the miniplayer in the bottom right.

ytd-watch-flexy[theater] #player-theater-container.ytd-watch-flexy,
ytd-watch-flexy[fullscreen] #player-theater-container.ytd-watch-flexy {
    height: calc((9 / 16) * 100vw);
    max-height: calc(100vh - 185px);
}
Zren commented 6 years ago

v119 will fix the 2 issues mentioned above, let me know if those aren't what you wanted fixed.

iPaulis commented 6 years ago

I meant the big player for the current video, not the small one (it has the same problem though). It only fails when the video has not started yet, with autoplay disabled. I see it also happens to you. This is my screenshot: thumbnail in black

My PREF is: f1=f1=50000000&al=es&f4=4000000 and my VISITOR_INFO1_LIVE is: yaavO4JW6bk

By reloading the page, I see the thumbnail appear for a split second, then something happens and goes to black.

Edit: thx, I will check v119 out and see if the thumbnail shows up.

Zren commented 6 years ago

Yep, I fixed that, try v119.

iPaulis commented 6 years ago

Yeah, awesome! It was so annoying not seeing which was the video for each tab among so many other tabs.

I've been using your script for a lot of years already, probably more than 5 or 6 years. It is so handy, thank you for making it.

Zren commented 6 years ago

And thank you for reporting the bug. :]

krystian3w commented 5 years ago

I can glitch after second minimalization to PIP mode:

obraz

PREF:f1=50000000 VISITOR_INFO1_LIVE:7e97ydBipzg

Firefox 63.0.1 x64, Windows 7 Pro x64, any script addon have similar glitch.

Zren commented 5 years ago

Yeah, the miniplayer's video element appears to be set to top: 381.5px;, if I remove that rule (so it's at 0) it shows up properly.

.video-stream.html5-main-video {
    top: 0 !important;
}

If I disable my script, the inline style css for the element is:

width: 400px;
height: 225px;
left: 0px;
top: 0px;

So my script is definitely messing with something.

Zren commented 5 years ago

@krystian3w try v121

krystian3w commented 5 years ago

OK, now after a second the video jumps up and is visible in PIP mode.