search

Zren / breeze-alphablack

Breeze Light theme with minor improvements and a black panel/titlebar.
https://store.kde.org/p/1084931/
35 stars 7 forks source link

Taskbar active selection color #10

Closed Cory-Watson closed 5 years ago

Cory-Watson commented 5 years ago

First off, this is truly one of the best plasma themes I have ever seen! Great work!

Do you know how I could change the color of the active selection in the taskbar? More specifically, I guess one could say it's an issue with the active selection of any applet in the panel because the systray and the application menu have the same behavior.

taskbar_active_selection_color

Cory-Watson commented 5 years ago

I would be more than happy to provide a pull request, just haven't came across an effective way to fix this yet...

Cory-Watson commented 5 years ago

Closing issue, I just manually changed the DecorationFocus color values in the .local/share/plasma/desktoptheme/breeze-alphablack/colors file.

Zren commented 5 years ago

The tasks in the taskmanager widget use https://github.com/Zren/breeze-alphablack/blob/master/widgets/tasks.svg

If you look at the svg's text, you'll notice the focus- elements use the class="ColorScheme-ButtonFocus" + style="fill:currentColor" to draw the color of those lines.

https://github.com/Zren/breeze-alphablack/blob/master/widgets/tasks.svg?short_path=6c8cc3e#L77

If we look at Plasma's code, ButtonFocus is generated using %buttonfocuscolor which is generated using color(Theme::FocusColor, Theme::ButtonColorGroup)

The color(...) function tells us it uses scheme->decoration(KColorScheme::FocusColor) where scheme = &buttonColorScheme.

https://github.com/KDE/plasma-framework/blob/9fc663d9f0edf41acd098b7c6c7b090d2c7b5aea/src/plasma/private/theme_p.cpp#L678

So we need to edit [Colors:Button] DecorationFocus=30,146,255 in the colors file.

https://github.com/Zren/breeze-alphablack/blob/master/colors#L24

I should note, sethighlightcolor.py essentially calls _applyColors(...) in desktoptheme.py. It uses that single highlightColor to generate a focusColor using focusColor = hoverEffect(highlightColor, -31, -28, 25) which lowers the red + green, and adds some blue.

issue was closed ... Well, now you know how it works.

Cory-Watson commented 5 years ago

Awesome! Thanks for the Plasma crash course!