Zren / breeze-alphablack

Breeze Light theme with minor improvements and a black panel/titlebar.
https://store.kde.org/p/1084931/
35 stars 7 forks source link

Without a generated dialogs/background.svg the Background Contrast effect is used #21

Closed Zren closed 3 years ago

Zren commented 3 years ago

Since breeze-alphablack inherits the default (Breeze) desktoptheme, it should be using it's dialogs/background.svg. The popup corners look correctly rounded so it's definitely inherited correctly. The problem seems to be that when we inherit the background.svg, it's using the light theme's contrast metadata.

2020-12-11___13-07-49 2020-12-11___13-08-02

When we generate a dialogs/background.svg using the AlphaBlackControl widget, it looks correct.

2020-12-11___13-09-13

After finding out it's the desktop effect, I dived into all the contast metadata, and found that Breeze add this to the metadata.desktop:

[ContrastEffect]
enabled=true
contrast=0.2
#intensity is disabled, in order to auto adjust to the chosen theme color
#intensity=2.0
saturation=1.7
Zren commented 3 years ago

Changing to enabled=false does not fix things. It still inherits the enabled=true from Breeze I think.

Using breeze-dark's contrast values is better, but isn't exactly the same color as shipping our own background.svg. The panel is also a different color.

2020-12-11___13-30-37