Zren / breeze-alphablack

Breeze Light theme with minor improvements and a black panel/titlebar.
https://store.kde.org/p/1084931/
35 stars 7 forks source link

Plasma 6 compatibility? #28

Open mmcnutt opened 7 months ago

mmcnutt commented 7 months ago

I'm not sure if you're still maintaining the alphablack control widget, but the widget does not appear to work with Plasma 6. The themeing is still applied from before the upgrade, however the widget no longer shows up in the tray.

The python script still appears to be effective for changing parameters tho

D3SOX commented 3 months ago

Sadly this seems to be unmaintained too https://github.com/Zren/plasma-applet-alphablackcontrol I will try and see if I'm able to update the code to work with Plasma 6. I found docs for it: https://develop.kde.org/docs/plasma/widget/porting_kf6/

D3SOX commented 3 months ago

image

I'm not that experienced with coding Plasmoids so it looks really buggy right now and you need to resize the applet as the scrolling is broken but at least the applet works now.

Changing colors and the opacity sliders work, the radio buttons for the style are a bit glitchy and the buttons to apply/reset title bar colors are missing

If anybody wants to help: https://github.com/D3SOX/plasma6-applet-alphablackcontrol

dhruv8sh commented 3 months ago

Okay so I have the applet running almost perfectly on my system. I need instructions on installing the theme itself so I can test and debug it.

image

Also I wrote a quick guide to plasma 6 applets. Here: https://medium.com/@dhruv8sh_34505/write-an-applet-for-plasma-6-0b8fd3a0334f

D3SOX commented 3 months ago

Works perfectly fine for me with your repo image

I've had the theme installed before via the KDE Store, I think. The theme might also need a port from metadata.desktop to metdata.json

D3SOX commented 3 months ago

image Ok radio buttons are also broken

And color pickers and also manually entering colors don't work. They worked in my repo. I think it's because you haven't migrated the kuser.loginName yet.

dhruv8sh commented 3 months ago

I am aware of this, I haven't pushed it yet. At least ask next time, lol. I also ported the .desktop to .json.

D3SOX commented 3 months ago

Oh ok I didn't know just wanted to test for you sorry

dhruv8sh commented 3 months ago

Latest commit should work just fine. Test it out and let me know if it works.

D3SOX commented 3 months ago

Radio buttons work fine now.

Changing colors in the UI works but has no effect

And what's also an issue is that I can't see the applet by default in the systray and have to enable it every time image

dhruv8sh commented 3 months ago

This will take up too much time! I need to find a way to install the theme instead. Edit: I have succeed in installing the theme. I will not debug it myself and notify you when the applet works completely.

dhruv8sh commented 3 months ago

Check now, seems to be working for me!

D3SOX commented 3 months ago

Yup changing colors works but I still think the effect should be automatically shown, dunno why it's not "relevant"

dhruv8sh commented 3 months ago

I don't get what you mean, elaborate please?

D3SOX commented 3 months ago

I think maybe widgetsUnlocked does not work correctly on Plasma 6 or some check when to show the applet

See previously you didn't have to manually add the Control Widget to use it. It would be inside the System tray (apparently when widgetsUnlocked not sure about that variable)

I think it was there in the overflow menu (bad visual representation): image

Now it's not there when I want to use it I must set this to always shown

image

Then it's directly an icon inside the systray

image

I've also tried to manually add it to my panel but I only see that when I'm in edit mode so I can't click it

dhruv8sh commented 3 months ago

Fixed! Since this issue does not seem to be watched over, I will publish it on the store myself.

D3SOX commented 3 months ago

Fixed! Since this issue does not seem to be watched over, I will publish it on the store myself.

Thank you so much! Yeah, I think that's a good idea, the repos seem to be unmaintained

I'm gonna create an AUR package for it

D3SOX commented 3 months ago

I just noticed the control applet only works when the theme is installed as user because of the way it works internally to change the settings, so packaging the theme with the current structure doesn't work.

Nevertheless I've packaged the control plasmoid: https://aur.archlinux.org/packages/plasma6-applets-breeze-alphablack

D3SOX commented 3 months ago

So I think it would be best if you could also publish the theme on the KDE Store with the control plasmoid as a dependency so it gets automatically installed, like it was before ^^

I also found another small bug: When setting it to be always hidden (as you are not really changing this that often) makes it so that when you click it in the overflow menu it doesn't open up.

image

dhruv8sh commented 3 months ago

Please open an issue in the new repo. I will get to this tomorrow.

D3SOX commented 3 months ago

I would've posted it there but issues are not open in your fork

dhruv8sh commented 3 months ago

😅yes that's on me. They're open now.

D3SOX commented 3 months ago

@mmcnutt I think you can close this issue here now and follow the respective repos of @dhruv8sh

Zren commented 3 months ago

Fixed! Since this issue does not seem to be watched over, I will publish it on the store myself.

I was waiting for a PR since there's a dozen other widgets to port and I've only recently setup a Plasma 6 VM and am currently working on a script to quickly replace keywords.

That said, I do have other widgets to port so you're free to maintain the widget going forward. I'll send you PRs if I add new features to the DesktopTheme python script.

So I think it would be best if you could also publish the theme on the KDE Store with the control plasmoid as a dependency so it gets automatically installed, like it was before ^^

Ah, in the case that you do add new features and upload your own DesktopTheme, make sure to add [Plasma 6] to the theme title, and I'll add [Plasma 5] to mine.

dhruv8sh commented 3 months ago

Sounds great! I am also working on a rust program to replace the keywords as well. Maybe we can collaborate on this.