Zren / chrome-extension-imagus

"Mirror" of the official Imagus source hosted on Google Drive
https://drive.google.com/drive/folders/0Bx8fnUCX4W2IaFVqdzRsNm9feG8
59 stars 23 forks source link

Option for caption outside of image #4

Open MaggiWuerze opened 6 years ago

MaggiWuerze commented 6 years ago

could you add an option to display the caption UNDER the image. This way it would not obscure the image when wrapped. I managed to do it via chrome dev console simply by setting the following properties of the surrounding div:

image

image

DanielBiegler commented 6 years ago

This I'd love as well. I can take a look at it later. Are you still interested in this @MaggiWuerze ?

MaggiWuerze commented 6 years ago

Yeah definitely, i can't live without this extension and this has bugged me for some time. Thanks for looking into it

MaggiWuerze commented 5 years ago

is there any progress regarding this feature?

DanielBiegler commented 5 years ago

Oh hey there, thanks for reminding me. I just spent some time to implement it here: https://github.com/DanielBiegler/chrome-extension-imagus/tree/feature/caption-under-media-with-wordwrap

I guess before this should be merged, the options page should be edited as well. I commited only twice, check it out.

Got to go now, will check it out later.

MaggiWuerze commented 5 years ago

really nice, looks good to me. Are you planning to give an option for max-height when you touch the options page??

DanielBiegler commented 5 years ago

Yeah one should also keep in mind the options for Captions in the imagus settings. There are options for the position. I hardcoded it to be on the bottom, it would be way better to respect the optionspage. I might check it out later but would be cool if you wanna help out.

MaggiWuerze commented 5 years ago

i'll have a look at how it could be positioned

MaggiWuerze commented 5 years ago

ok, it seems if you just switch the order of the <img> and the <div> containing the caption when the caption should be displayed on top and set the captions position to initial (as you already did) it works pretty flawless