search

Zren / material-decoration

Material-ish window decoration theme for KWin, with LIM, based on zzag's original design.
GNU General Public License v2.0
197 stars 17 forks source link

No red/grey background on hover in Firefox CSD #27

Open taprobane99 opened 3 years ago

taprobane99 commented 3 years ago

hi,

is this the fault of Firefox or your theme?

also buttons are smaller than in KDE Plasma native apps. size change has no effect.

Zren commented 3 years ago

Hmm, looks like my workaround for Issue #22 might no longer working. I can reproduce this.

Weird, when i restart kded5 (don't try this) for testing it seems to work. I'll need to restart my computer to see if kded5 behaves differently after boot. It's possible that there's different environment variable from a kded5 launched at boot and when I restart it for testing. Odd.

taprobane99 commented 3 years ago

hi, still the same after reboot. medium size is perfect for native apps, but renders about 30% smaller on Firefox.

i think the missing red/gray background on hover might just be a limitation of CSD. but perhaps you could change the CSD mouseover buttons to be more different to the normal ones? because currently almost no visual change occurs when hovering over a button in Firefox.

taprobane99 commented 3 years ago

@Zren , just to follow up on this, the X on Firefox and other GTK apps is 14x14 pixels on my system, whereas on Qt KDE apps its 16x16 pixels.

So perhaps if you reduced kwin padding in the fix you made earlier by another 2 pixels it would solve this bug in a very simple way?

https://github.com/Zren/material-decoration/commit/65fe6f577a978a9e601241d29bea35185eb7f69c