Zren / material-decoration

Material-ish window decoration theme for KWin, with LIM, based on zzag's original design.
GNU General Public License v2.0
197 stars 17 forks source link

Non-empty borders should be respected by theme #38

Open ancwrd1 opened 3 years ago

ancwrd1 commented 3 years ago

If the borders are set to something other than None the theme selection color overlaps the top border. See attached screenshots:

menu

button

Zren commented 3 years ago

2021-03-08___11-30-29

The outline is drawn on top of the hovered rect.

I'm not sure if adding .adjusted(0, 1, 0, 0) to the button's background fill would look much better.

https://github.com/Zren/material-decoration/blob/master/src/Button.cc#L221

ancwrd1 commented 3 years ago

I tried it with .adjusted(0, 2, 0, 0) and it does look better I think:

Screenshot_20210308_182206

ancwrd1 commented 3 years ago

Also reducing one pixel from the bottom makes the menu hovering look slightly better.