Zren / material-decoration

Material-ish window decoration theme for KWin, with LIM, based on zzag's original design.
GNU General Public License v2.0
197 stars 17 forks source link

Sliver of Active/Inactive Color Stuck In Titlebar With Borders #41

Open janlimpens opened 3 years ago

janlimpens commented 3 years ago

Screenshot von 2021-03-16 11 23 45

Currently, I cannot define a difference between active and inactive windows, which leads to confusing overlapping where it is difficult to say, where one application window ends and another starts.

Material decoration should simply take the colours defined in system configuration and everybody would be happier.

Zren commented 3 years ago

Pretty sure it uses the Color Theme's colors doesn't it?

2021-03-16___10-26-07

Zren commented 3 years ago

Hmmm, you did make me notice a bug in the border code. Apparently there's a tiny sliver doesn't get repainted. It sticks with whatever color it had when the color theme was selected. So System Settings has the active color, and other windows have a sliver colored inactive.

2021-03-16___10-29-56

janlimpens commented 3 years ago

Ok, something had been stuck here. I switched around different themes and suddenly color changed to what i was supposed to be,

-- jan

//jan.limpens.com

---- Ein Di, 16 Mär 2021 11:29:14 -0300 Chris Holland @.***> schrieb ----

Pretty sure it uses the Color Theme's colors doesn't it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

janlimpens commented 3 years ago

Hmmm, you did make me notice a bug in the border code. Apparently there's a tiny sliver doesn't get repainted. It sticks with whatever color it had when the color theme was selected. So System Settings has the active color, and other windows have a sliver colored inactive.

This, on the other hand, does not appear here.

Zren commented 3 years ago

This, on the other hand, does not appear here.

Do you have a border thickness set? I'm changed "No Borders" to "Thin" which is a 1px border. Change the color theme afterward, the select an inactive window you already had open.

janlimpens commented 3 years ago

I did not find an option to set border thickness.

jan

//jan.limpens.com

---- Ein Di, 16 Mär 2021 11:37:17 -0300 Chris Holland @.***> schrieb ----

This, on the other hand, does not appear here. Do you have a border thickness set? I'm changed "No Borders" to "Thin" which is a 1px border. Change the color theme afterward, the select an inactive window you already had open. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

Zren commented 3 years ago

It's not in the config popup. It's a setting at the bottom of the theme selector grid.

2021-03-16___10-45-11

janlimpens commented 3 years ago

Ok, found it, but I did not see any artefacts after doing what you described.

-- jan

//jan.limpens.com

---- Ein Di, 16 Mär 2021 11:46:26 -0300 Chris Holland @.***> schrieb ----

It's not in the config popup. It's a setting at the bottom of the theme selector grid.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

Zren commented 3 years ago

Hmm, I test again when I get back to X11 from Wayland. I doubt that's the issue though. I'm renaming this issue though since all the screenshots are here already.

giomatfois62 commented 3 years ago

I'm also experiencing this issue, I use normal borders and X11 session. far right corner of the titlebar is stuck with the active color when the window looses focus. Did not spot any obvious suspect in your painting code yet.