Build failed on Tumbleweed

[trmdi]

Build log: https://build.opensuse.org/package/live_build_log/home:trmdi/material-decoration/openSUSE_Tumbleweed/x86_64

[Zren]

Ah yep, can reproduce. Seems there's a new deprecation.

[ 80%] Building CXX object src/CMakeFiles/materialdecoration.dir/BoxShadowHelper.cc.o
/home/chris/Code/kdecommunity/material-decoration/src/AppMenuModel.cc: In member function ‘void Material::AppMenuModel::x11Init()’:
/home/chris/Code/kdecommunity/material-decoration/src/AppMenuModel.cc:124:121: error: ‘void KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2)’ is deprecated: Since 5.101. Use KX11Extras::windowChanged [-Werror=deprecated-declarations]
  124 |     void (KWindowSystem::*myWindowChangeSignal)(WId window, NET::Properties properties, NET::Properties2 properties2) = &KWindowSystem::windowChanged;
      |                                                                                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/KF5/KWindowSystem/KWindowSystem:1,
                 from /home/chris/Code/kdecommunity/material-decoration/src/AppMenuModel.h:36,
                 from /home/chris/Code/kdecommunity/material-decoration/src/AppMenuModel.cc:28:
/usr/include/KF5/KWindowSystem/kwindowsystem.h:980:10: note: declared here
  980 |     void windowChanged(WId id, NET::Properties properties, NET::Properties2 properties2); // clazy:exclude=overloaded-signal
      |          ^~~~~~~~~~~~~
/home/chris/Code/kdecommunity/material-decoration/src/AppMenuModel.cc:124:121: error: ‘void KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2)’ is deprecated: Since 5.101. Use KX11Extras::windowChanged [-Werror=deprecated-declarations]
  124 |     void (KWindowSystem::*myWindowChangeSignal)(WId window, NET::Properties properties, NET::Properties2 properties2) = &KWindowSystem::windowChanged;
      |                                                                                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/KF5/KWindowSystem/kwindowsystem.h:980:10: note: declared here
  980 |     void windowChanged(WId id, NET::Properties properties, NET::Properties2 properties2); // clazy:exclude=overloaded-signal
      |          ^~~~~~~~~~~~~
/home/chris/Code/kdecommunity/material-decoration/src/AppMenuModel.cc:131:52: error: ‘void KWindowSystem::windowRemoved(WId)’ is deprecated: Since 5.101. Use KX11Extras::windowRemoved() [-Werror=deprecated-declarations]
  131 |     connect(KWindowSystem::self(), &KWindowSystem::windowRemoved,
      |                                                    ^~~~~~~~~~~~~
/usr/include/KF5/KWindowSystem/kwindowsystem.h:904:10: note: declared here
  904 |     void windowRemoved(WId id);
      |          ^~~~~~~~~~~~~
[ 83%] Building CXX object src/CMakeFiles/materialdecoration.dir/MenuOverflowButton.cc.o
cc1plus: all warnings being treated as errors
make[2]: *** [src/CMakeFiles/materialdecoration.dir/build.make:99: src/CMakeFiles/materialdecoration.dir/AppMenuModel.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:295: src/CMakeFiles/materialdecoration.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Caused by this commit to KWindowSystem:

• https://invent.kde.org/frameworks/kwindowsystem/-/commit/7cfd7c36eb017242d7a0202db82895be6b8fb81c

For reference, here's how libtaskmanager fixed this deprecation:

• https://github.com/KDE/plasma-workspace/commit/a9b1940c7e8aa8ae2fec925fb884f4e66ff22936#diff-f170158646a7d961770ad9c01914adf95b83de1868a084b2f28db4545f09e6ccL28

Might be a little annoying since I probably need to support both KF5 5.101+ and KF5 5.100 and below, so I'll be using #IF KF5_MINOR_VERSION <= 100 probably. Though I'll probably also need to parse the major version and check if <= 5 too.

[Zren]

Not sure how to trigger a rebuild, but that should fix it.

[trmdi]

Not sure how to trigger a rebuild, but that should fix it.

I triggered it and succeeded. Thank you !