search

Zren / material-decoration

Material-ish window decoration theme for KWin, with LIM, based on zzag's original design.
GNU General Public License v2.0
200 stars 17 forks source link

Plasma 6 compatibility #73

Open guiodic opened 8 months ago

guiodic commented 8 months ago

Hi, is an update planned for Plasma 6?

Thank you!

guiodic commented 7 months ago

Plasma 6 was released today. I hope this decoration can be updated to the new DE. Thank you!

guiodic commented 6 months ago

Sorry, a gentle bump :)

AntarEspadas commented 6 months ago

I am also curious if an update is planned

abolast commented 6 months ago

I regret not having learned C++. C++ is too difficult. Similarly, this tool can improve my work efficiency.

guiodic commented 6 months ago

I am seeing that @Zren is prioritizing widgets, I hope he has time for this decoration, much of the work I think has already been done. I really can't get by without the LIM!

nicman23 commented 5 months ago

I am independently working on it, I just need to figure out kconfig but it is so boring as I do not use the kconfig menu, as I always just changed the source code

guiodic commented 5 months ago

Thank you very much!

Il mar 9 apr 2024, 12:19 nicman23 @.***> ha scritto:

I am independently working on it, I just need to figure out kconfig but it is so boring as I do not use the kconfig menu, as I always just changed the source code

— Reply to this email directly, view it on GitHub https://github.com/Zren/material-decoration/issues/73#issuecomment-2044653776, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACH63BB5XZBZCG2OSND7BDY4O6E7AVCNFSM6AAAAABCFC2OXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBUGY2TGNZXGY . You are receiving this because you authored the thread.Message ID: @.***>

guiodic commented 5 months ago

@nicman23 do you have any news? Is it possible to test the decoration?

nicman23 commented 5 months ago

sorry guys it is a tough month, i might just upload whatever i have already done but yeah i have not worked at it at all

guiodic commented 5 months ago

Thank you very much! I dont care kconfig for now, default options are ok for me, I will eventually change source code. Or, if present, the values in kwinrc.

guiodic commented 5 months ago

@nicman23 sorry to bother you but... any news?

nicman23 commented 5 months ago

sorry here is the wip code https://github.com/nicman23/material-decoration but still no progress since my first message

guiodic commented 5 months ago

thank you. I tried to build it. I receive an error on qtdbusmenu so I tried commenting the line in cmake but then I receive another error on "FindQt.cmake". Well, I will wait...

Anarcraft commented 5 months ago

On my test machine I don't see a package named "Qt6" which this would parse to: find_package(QT NAMES Qt${QT_VERSION_MAJOR}) It may be the package named "Qt6-base".

guiodic commented 5 months ago

On my test machine I don't see a package named "Qt6" which this would parse to: find_package(QT NAMES Qt${QT_VERSION_MAJOR}) It may be the package named "Qt6-base".

I presume "package" in cmake refers to QT internal names, not to the packages from the distribution.

Anarcraft commented 5 months ago

On my test machine I don't see a package named "Qt6" which this would parse to: find_package(QT NAMES Qt${QT_VERSION_MAJOR}) It may be the package named "Qt6-base".

I presume "package" in cmake refers to QT internal names, not to the packages from the distribution.

Oh, OK, I don't know much about cmake.

guiodic commented 5 months ago

@nicman23 sorry to bother you again ...

nicman23 commented 5 months ago

i ll take a crack at it if i have no work today

nicman23 commented 5 months ago

i did make it compile but it does not show up in system config. if at all possible @Zren could you take a look?

it is not buy any way ready - i have removed the configuration for now - but it should had worked (?)

just for reference it compiles with qt6 and kf6

guiodic commented 5 months ago

thank you. I still receive this error:

CMake Error at /usr/lib/cmake/Qt6DBus/Qt6DBusMacros.cmake:64 (qt5_add_dbus_interface): Unknown CMake command "qt5_add_dbus_interface". Call Stack (most recent call first): src/libdbusmenuqt/CMakeLists.txt:24 (qt_add_dbus_interface)

guiodic commented 5 months ago

and if I comment the qt dbusmenu including in cmake, thei I receive this other error: CMake Error at /usr/lib/cmake/Qt6Qml/Qt6QmlMacros.cmake:2829 (message): qt_generate_foreign_qml_types() is only available in Qt 6. Call Stack (most recent call first): /usr/lib/cmake/Qt6Qml/Qt6QmlConfig.cmake:145 (include) /usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package) /usr/lib/cmake/KF6Config/KF6ConfigConfig.cmake:53 (find_dependency) /usr/share/ECM/find-modules/FindKF6.cmake:52 (find_package) src/CMakeLists.txt:13 (find_package)

(I'm on Manjaro unstable, it's pretty the same of arch)

guiodic commented 5 months ago

p.s. I use this command to build: cmake -DCMAKE_INSTALL_PREFIX=/usr ..

nicman23 commented 5 months ago

try cmake -DQT_MAJOR_VERSION=6 -DCMAKE_INSTALL_PREFIX=/usr ..

guiodic commented 5 months ago

yes, it works! thank you! but it has not shadow

guiodic commented 5 months ago

i tried to add this to kdecoration_materialrc

[Common] MenuAlwaysShow=true ShadowStrength=128

but the shadow doesn't show. Anyway the menu works

nicman23 commented 5 months ago

what? tf, it does not work on my machine :D

E: huh the .so is installed in the wrong folder. i do not care to look into it right now, i just did a

cp src/materialdecoration.so /usr/lib/qt6/plugins/org.kde.kdecoration2/

and it worked lol

guiodic commented 5 months ago

@nicman23 I hope the shadows can be restored.

nicman23 commented 5 months ago

i do not use them so probably eh maybe

guiodic commented 5 months ago

i do not use them so probably eh maybe

Please 🙏🙏🙏

guiodic commented 5 months ago

@nicman23 can you at least make some suggestions? I tried fiddling with the code but couldn't solve the shadow problem. Thank you!

@Zren some love for this bug? Thanks!

guiodic commented 4 months ago

Sorry again @nicman23 ...

guiodic commented 4 months ago

To restore shadows, in the Decoration.cc, line 567

if (!s_cachedShadow ---> if (s_cachedShadow

guiodic commented 4 months ago

Is there any chance of this decoration being ported to Wayland?

nicman23 commented 4 months ago

no

guiodic commented 4 months ago

no

maybe @Zren ?

nicman23 commented 4 months ago

no i mean it is currently not possible

guiodic commented 4 months ago

no i mean it is currently not possible

Can you explain why? Thank you!

HerrCraziDev commented 3 months ago

no i mean it is currently not possible

Can you explain why? Thank you!

Because Wayland sucks. It's much more restrictive than X11.

Also, any progress on this ?

guiodic commented 3 months ago

no i mean it is currently not possible

Can you explain why? Thank you!

Because Wayland sucks. It's much more restrictive than X11.

Also, any progress on this ?

I agree on Wayland sucks etc. but in this particular case I think there are no major problems, in fact the global menu and the menu button in the title bar work correctly (at least for QT apps, the GTK ones have a problem upstream)

HerrCraziDev commented 1 week ago

Damn I'll have to switch to Debian /s