search

Zren / mpv-osc-tethys

An OSC UI replacement for MPV with icons from the bomi video player. Also contains thumbnail preview and a picture-in-picture button.
187 stars 13 forks source link

Lag when using tumbnails #3

Closed ang3lo-azevedo closed 2 years ago

ang3lo-azevedo commented 2 years ago

Hello, I have a problem. When watching anything on mpv the tumbnails from osc tethys lag all the interface and even make it freeze.

Could you help me?

Thanks

Zren commented 2 years ago

Atm, the thumbnail generation is blocking. I added a debounce delay to generate the thumbnail if you stop moving the mouse for 200ms, but it's not working very well.

I was hoping to keep this as a single script to make it easier to install, but it seems there's a reason that https://github.com/TheAMM/mpv_thumbnail_script/releases is two different lua scripts.

I've tested a quick refactor using mpv_thumbnail_script_server.lua and it seems to work well. I've just gotta polish it and remove my old thumbnail code before releasing it.

Zren commented 2 years ago

Try the thumbserver branch:

ang3lo-azevedo commented 2 years ago

Thank you!

ang3lo-azevedo commented 2 years ago

And how can I make the tumbnails work on remote files?

Zren commented 2 years ago

https://github.com/Zren/mpv-osc-tethys#mpv_thumbnail_scriptconf

# Allow thumbnailing network paths (naive check for "://")
thumbnail_network=yes