Open AndydeCleyre opened 8 years ago
Unfortunately, none of those are in the default breeze icon set (/usr/share/icons/breeze/
). I could probably check if the symbolic icon exists, then use the fallback coloured version if it doesn't.
preferences-system-bluetooth
is in the default breeze icon theme which is a symbolic bluetooth icon. Do you thin speakers with a name that start with bluez_sink.
is unique enough to choose this icon?mic-on
and mic-off
. I should change change the mute button instead with microphone-sensitivity-muted
microphone-sensitivity-low
microphone-sensitivity-medium
and microphone-sensitivity-high
. It looks like I'll need to look for microphone-sensitivity-muted-symbolic
etc which papirus supports.So I wrote some simple fallback code, but found out that breeze's audio-speakers-symbolic
is the "volume icon", which means that while it'll look good in papyrus, it would then look bad with breeze icons. :/
@Zren ah, I can see that they link the device icon audio-speakers-symbolic
(clearly within a devices
directory) to the status icon audio-volume-high
(clearly within a status
directory).
In my opinion this is a bug in the Breeze icon set. So I reported it.
it would then look bad with breeze icons
Doesn't everything? 😂
Hi as breeze icon maintainer I'm still open to add new icons or change stuff.
The goal is to find a good icon to represent the 3.5mm headphone jack "speaker" in the system tray, that's different from the current volume icon. Ideally it should be different in all icon themes.
Plasma-pa uses the audio-card
in the widget configuration page. My widget shows both the "built-in audio device" microphone and speaker at the same time however, which both use audio-card
, so we need a distinct icon for each.
Here's an in progress list of all icons side by side (beware as I update it with other themes).
So my code the fallback to certain icons doesn't work as well as I hoped. IconItem { source: 'audio-speakers' }
is treated as a valid icon since it is resolving to a mimetype icon. Every "missing" icon starting with "audio" uses that so that
I've figured out a way to use my own svg that follows the color scheme. So I could just use a bunch of good icons instead of leaving it up to the theme. It won't use the color scheme in the tooltip though since I need to load it with SvgItem to use the color scheme.
PlasmaCore.SvgItem {
svg: PlasmaCore.Svg {
imagePath: Qt.resolvedUrl('../icons/' + mixerItem.icon + '.svg')
}
}
Anyways, I bound speakers starting with bluez_sink.
to the preferences-system-bluetooth
icon which is a fairly symbolic icon.
Thanks again for this, and for making it better!
I think the icon choices for the mixer elements could be improved.
The generic speaker icon is identical to the ones underneath the sliders, which seems redundant and obscures the difference in function. The new HDMI icon feels out of place.
I suggest the following user theme icons be used for the corresponding Port values on the mixer elements:
I notice the microphone icon gets colorized when muted. I don't know how exactly that's accomplished right now, but as all the suggested icons are symbolic, it should be possible to colorize them if you want to apply plasma theme colors and mute colors to them.