Zren / plasma-applets

This monolithic repo has been broken up into individual repos for each widget.
84 stars 23 forks source link

Suppress incorrect MPRIS SetPosition calls on loading new media #69

Closed davidedmundson closed 7 years ago

davidedmundson commented 7 years ago

In order to tell between user created slider valueChanged events and synthetic ones the code has a disablePositionUpdate flag which is set when updating the value.

setting Slider.maximumValue implicitly will also change value, so it needs the same logic.

This fixes a bug where opening a new media file will resume at the point where a previous media file left off.

Zren commented 7 years ago

Ah you're right, not sure how I missed that (or if I was lazy when implementing it).

https://github.com/KDE/plasma-workspace/blob/master/applets/mediacontroller/contents/ui/ExpandedRepresentation.qml#L70