Zren / plasma-wallpapers

45 stars 9 forks source link

Idea: Support for wallpaper slideshows #1

Closed mleko69 closed 5 years ago

mleko69 commented 6 years ago

This wallapaper blur plugin is so amazing. Possibility to use slideshows would make it even more sexy! :)

Also I've noticed a bug: alt-tabbing windows turns off the blur. Moving active window by at least 1px enables the blur again.

Screen 1. Proof of bug screenshot_20180105_180535

Screen 2. Moving active window turns the blur on again screenshot_20180105_180552

Zren commented 6 years ago

I can't seem to reproduce.

https://streamable.com/8c2jg

Last I checked, the slideshow wallpaper either had a cpu bug or memory leak in Qt 5.9+, so I wouldn't be able to copy the existing code straight from it. That said, it wouldn't be too hard to workaround.

The slideshow does a fade between images using a complex animation.

https://github.com/KDE/plasma-workspace/blob/master/wallpapers/image/imagepackage/contents/ui/main.qml#L183-L227

A simpler animation could be done. A "fade to black" then swaps image then "fade in" might be possible.

The whole reason the bug exists is that it's using ParallelAnimation... I think. I'm fairly certain SequentialAnimation by itself would probably be okay.

Zren commented 5 years ago

Implemented in v2.