Zrips / CMI

117 stars 99 forks source link

/condense with glowstone dust doesn't work #2251

Closed ludvdber closed 5 years ago

ludvdber commented 5 years ago

Description of issue: /condense with glowstone dust doesn't work

CMI plugin version: 8.6.10.0 BungeeCord Server version: Paper(175) 1.14.4-R0.1-SNAPSHOT Vault version: 1.7.3-b${env.TRAVIS_BUILD_NUMBER}

mercurialmusic commented 5 years ago

I don't think it's supposed to by default -- it doesn't work that way in Essentials either (or didn't used to) -- and personally I like it the way it is. Condense will craft items that can be easily uncrafted again (or /uncondense) -- but with things like glowstone or melon block or quartz, if you accidentally condense those items, you can't get the materials back without breaking the block, or never in the case of quartz. It's a very smart way of fool-proofing.

BUT you can already add this yourself - see Zrips's comments on the half dozen or so people who already asked for this -- handy to do a search before posting duplicates. See #2232, #1320, #1145, #811, etc.

Momshroom commented 5 years ago

With essentials, /condense won't condense items that are not easily uncondensable, BUT /condense (name) or /condense hand will. This makes sure the player actually wants these items condensed but doesn't remove the ability to do so: a very nice compromise. Similar to how essentials allows /sell (name), another feature my players miss. (/sell same partially fixed this). /condense hand or /condense same would also allow players to condense some items without condensing everything, another lost functionality relative to Essentials, and very useful at times. And adding this compromise would allow condense to work on these items without making items that are not intended to be uncondensable incondensable.