search

Zrips / CMI

114 stars 97 forks source link

Players can copy Admin sign shops with "/cmi sc" #3070

Closed BboyZeroOne closed 4 years ago

BboyZeroOne commented 4 years ago

Description of issue: Players can use the command "/cmi sc" to duplicate any admin sign shop. The sign shop would work since its a duplicated sign. They should not have access to sign copy any admin related sign shop.

Cmi Version (using/cmi version): 8.6.21.5

Server Type (Spigot/Paperspigot/etc): Paper Spigot

Server Version (using /ver): git-Paper-155 (MC 1.15.2)

Relevant plugins (Delete if this isn't needed): https://www.spigotmc.org/resources/chestshop.51856/

mrfloris commented 4 years ago

Isn't SC a tool for staff and not for players? I don't know how cmi would know if one sign is any different than another, unless it's made with cmi itself (but i dont think sc would check for that)

BboyZeroOne commented 4 years ago

Well, it could also be a tool for players isn't it? Unless I'm wrong. Regardless, it shouldn't copy signs from other plugins.

ghost commented 4 years ago

It has no way to know that a sign is from another plugin though.

Zrips commented 4 years ago

Will introduce somewhat workaround for this one, should help out

BboyZeroOne commented 4 years ago

Hmm, the latest update still allows players to /sc on admin shop signs though.