Zrips / CMI

114 stars 97 forks source link

Dissapears items when player hold and /inv #5627

Closed iBuseWinner closed 3 years ago

iBuseWinner commented 3 years ago

Description of issue: When Player1 take item with LC (left click) E.g. image

And Player2 use command /inv Player1 This item disappears


Cmi Version (using/cmi version): 8.8.4.4

Server Type (Spigot/Paperspigot/etc): Purpur

Server Version (using /ver): [15:53:35 INFO]: This server is running Purpur version git-Purpur-1135 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT) You are 3 version(s) behind Previous version: git-Hyalus-202 (MC: 1.16.5

CloudeLecaw commented 3 years ago

why you let view inyour players inventories and let them take their items out? sounds like a great server to troll each other and take out everyones items. You also could descripe the issue: Troll1 use /inv Player2 when player2 wonders why all his items disapeaer. LC an item means - it taken out. taken out means it not there. that simple :3 Mousehold items are saved nowhere. what is the reason why you thought they disapear. inv loads the inventory slots not a mousehold anywhere item... so blopp it may dispears. if the Admin or who ever took out an item with LC he had a reason for doing this. So its ok when it really disapears in unsuported server forks ;) There might be nothing what Zrips can do there.

so pls thing of what you allow for your player... if you allow viewing of inventory for players then you should prevent modifications (take items in and out) permissions for this could be cmi.command.inv.preventmodify for players cmi.command.ender.preventmodify for players

iBuseWinner commented 3 years ago

why you let view inyour players inventories and let them take their items out?

Just to view, not to take items :/ Why you think that view == edit?

iBuseWinner commented 3 years ago

Mousehold items are saved nowhere. what is the reason why you thought they disapear. inv loads the inventory slots not a mousehold anywhere item... so blopp it may dispears.

Because of that item clears from inventory? Nice.

CloudeLecaw commented 3 years ago

U said:

This should not be possible for the viewer. So finaly this means u gave permission or your server or other plugin creates this currption. May the next bug of purpur?

On spigot + permsystem + cmi your issues is not reproduceable that way because p2 cant even take the item of p1 with LS in his mouse.

iBuseWinner commented 3 years ago

In your Pictures we see p2 holding Item of inventory of p1 with Mouse what means he can take items out.

Example what I mean. It isn't /inv

Zrips commented 3 years ago

@iBuseWinner Confirmed, will be fixed with next update