Zrips / CMI

117 stars 99 forks source link

Sleeping speedup broken #5765

Open MrLolok opened 3 years ago

MrLolok commented 3 years ago

Description of issue: Percentage of sleeping people to speedup the night doesn't work, on 70 players there are required the 100% of players to speedup


CONFIG SECTION:

Sleeping:
  Speedup:
    MinBeforeSpeeding: 10%

Cmi Version (using/cmi version): Versione di CMI: 9.0.0.3 BungeeCord SqLite [21:48:32 INFO]: CMILib: 1.0.2.4 [21:48:32 INFO]: Server: Purpur 1.17-R0.1-SNAPSHOT [21:48:32 INFO]: CMI economy: Disabilitato CMI Chat: Abilitato [21:48:32 INFO]: Modules -> 42 enabled 14 disabled: mirror, launchPad, moneyCheque, skin, jail, dynamicSigns, flightCharge, schedule, ranks, playerCombat, votifier, shulkerBackpack, headDrop, namePlates

Server Type (Spigot/Paperspigot/etc): Purpur

Server Version (using /ver): This server is running Purpur version git-Purpur-1208

Zrips commented 3 years ago

What does title message say when you enter bed? It should indicate need player amount. Keep in mind that it takes players from that world and not total amount of players from entire server.

CloudeLecaw commented 3 years ago

well on our server i see the title meassage all night minimum once even if we disabled it..

image

Zrips commented 3 years ago

@CloudeLecaw What type of message?

CloudeLecaw commented 3 years ago

We see a actionbar meassage like

3 / 4 player sleeping

The meassage disappears after a few secounds.

I found the line also in cmilibs translation folder

sleepersRequired: '!actionbar!&f[sleeping] &7of &f[required] &7sleeping from require

Well here is our config part

Sleeping:
  Speedup:
    # When set to true, players can speedup night by sleeping in bed
    # This will allow to speed up night in percentage depending how many players are sleeping in beds in that world
    Enabled: true
    # List of worlds where this should be applied.
    # Keep in mind that time speed up only works on a normal type world and by default you will have only one
    # Set this list to [] if you want to include all possible worlds
    Worlds: []
    # When this set to true time will be speed up only between 13000 and 24000 ticks of the day
    # When having this set to false players can speed up day durring storms or other events
    OnlyDurringNight: true
    # Type of speedup information, can be: none, title, bossbar
    InfoType: none
    # When set to true, players who are in afk mode will be excluded from speed calculations
    ExcludeAfk: true
    # Defines speed to go throw night, bigger numbers will make it go faster and less players you will need to go throw night
    # 100 will result in 100 times faster time
    BaseSpeed: 100
    # Defines minimal speed to go throw night, this is in case there are more players than base speed and calculation return default speed
    MinSpeed: 5
    # Minimal amount of players sleeping in beds before speeding it up
    # Can be defined in 2 formats. When using clean number like 3, then 3 players will have to be sleeping before speedup kicks in
    # If amount is defined with % like 50% then half of server population will have to be sleeping before speedup kicks in
    MinBeforeSpeeding: 100%
    # When set to true online players will be informed about missing sleeping people count
    Inform: false
    # Time in seconds between information messages can be shown when player starts or stops sleeping
    InformDelay: 100

The issue is... You see innconfig we have the inform set to false.. So the Actionbar meassage should not appear

MrLolok commented 3 years ago

What does title message say when you enter bed? It should indicate need player amount. Keep in mind that it takes players from that world and not total amount of players from entire server.

It says the required amount like 1 player out of 70 are sleeping. It should say 7 (10% of 70)

CloudeLecaw commented 3 years ago

Well We disabled the inform, so it should not be shown anywhere ;D Maybe a secounds issue with this feature

Zrips commented 3 years ago

Thats actually new feature of 1.17 minecraft itself. There is new game rule which can define amount of players needed to be sleeping for night to be skipped entirely which by itself prints out action bar message image Unless we are talking about something else here

CloudeLecaw commented 3 years ago

Thats actually new feature of 1.17 minecraft itself. There is new game rule which can define amount of players needed to be sleeping for night to be skipped entirely which by itself prints out action bar message image Unless we are talking about something else here

Yes extacly this one. What gamerule is it, and can it be disabled?:3

I see the gamerule us called playersSleepingPercentage

Zrips commented 3 years ago

It looks to be completely client sided message and cant find any way to disable this one.

SoniXlash commented 3 years ago

Fixing issue with night speed up not properly calculating total player count needed for sleep checkup

Not on 1.17.1 servers. Persentage still doesn't work CMI 9.0.4.2