Zrips / CMI

116 stars 98 forks source link

After the teleport, /fly is deactivated #7401

Closed Sh3r1ffCZ closed 1 year ago

Sh3r1ffCZ commented 1 year ago

Description of Issue

Hello, yesterday I updated the CMI plugin to the latest version and whoever activates /fly, after teleporting to another world /fly is deactivated. He has to type the command again to fly again.

I have AntiWorldFly, but i have same version more than 2 months and only for SpawnNew - Event world Thanks

Version Information

[18:22:25 INFO]: CMI: 9.2.5.5 BungeeCord MySQL
[18:22:25 INFO]: CMILib: 1.2.3.7
[18:22:25 INFO]: Server: Purpur 1.19.2-R0.1-SNAPSHOT
[18:22:25 INFO]: CMI economy: POVOLENO Vault: 1.7.3-b131(CMIEInjector) CMI Chat: ZAKAZÁNO
[18:22:25 INFO]: Modules -> 46 enabled 11 disabled: spawnerProximity, flightCharge, disabledEnchants, mirror, tablist, skin, noTarget, elytraBoost, spawnerCharge, paintingEditor, playerChatTag

Errors

No response

Relevant Config Sections

WorldLimits:
  # By setting to true fly and gamemode limitations per world will be aplied for player on world change if they dont have appropiate permission node
  Enabled: false

AntiWorldFly config:
antiFlyWorlds:
- SpawnNew

Relevant Plugins

AntiWorldFly-2.5.1

Agreements

Rexmen1 commented 1 year ago

Yea its bcz of latest update, It should disable fly only when they don't have fly permission or no flight charges left but its disabling everytime... I think for now going back to old method will be good until fixed...

mercurialmusic commented 1 year ago

Throwing my hat in this ring as well. The new behavior is god awful. It's even removing fly when in spectator mode and going between worlds. Now every time I change a world I'm having to redo fly, even as OP. At the very least the bypass permission should be respected here.

CloudeLecaw commented 1 year ago

it might has to do with the "fix" tat was made in latest version.

We also see this issue now on our server.

Fly gets disabled now each time someone even the owner changes a world.

Snag_a008c

log from latest version sais: Update for general fly mode handling when it comes to world changes which was bugging out and in some instances keeping fly mode enabled for the player when it should have been disabled

Valeoria commented 1 year ago

Same issue here. Players are losing fly when changing worlds no matter what we do. No permissions/settings have any effect. Even worldguard regions with "Fly:allow" do not work.

Please revert these changes ASAP.

Shaiiiiiiii commented 1 year ago

I have also had this issue. Some of my players when going into the overworld and back to spawn are not able to fly anymore. I have checked all the files and permissions and cant find a reason as to why this is happening.

Zrips commented 1 year ago

Oversight from my side, will issue fix for this one today

Rexmen1 commented 1 year ago

Still disables when changing worlds... Even when fly is allowed in those worlds...

mercurialmusic commented 1 year ago

Still disables when changing worlds... Even when fly is allowed in those worlds...

For what it's worth, it was fixed for me in the last update, so it might be down to your settings/config/permissions at this point.

CloudeLecaw commented 1 year ago

for us it also is fixed with the latest version. . your using any eventCommand that can disable it? if so add a little delay of 0.5 or 1 before the checks. with a line before delay! 1

Valeoria commented 1 year ago

The main issue was fixed for us, but fly is acting far different since these updates. We are dealing with many issues caused by this change. Obviously these are our issues as the methods used have all changed, but its frustrating to deal with.

Not sure these changes were needed in the first place as everyone has come to accept how cmi handled fly.

But yes, the latest update did fix the major issue this post was about.

Rexmen1 commented 1 year ago

Its working fine for op, but not for normal players and have no idea what permission to give at this point.. tried few

CloudeLecaw commented 1 year ago

Its working fine for op, but not for normal players and have no idea what permission to give at this point.. tried few

any eventCommand on worldxhange or teleported? any other plugin that change habit like Multiverse-Core? any other plugins that dies this? any worldlimits might set? its normal your ops would bypass these all

Rexmen1 commented 1 year ago

it was working fine before the update, so it shouldn't be an issue with other plugins... and works for me with owner op perms... So has to be cmi permission issue..

No world limits set either...

CloudeLecaw commented 1 year ago

it was working fine before the update, so it shouldn't be an issue with other plugins... and works for me with owner op perms... So has to be cmi permission issue..

No world limits set either...

You doing something perm related after teleporting or worldchange? defined in eventCommands.yml ? if so you might should add a delay a little before the checks

Sh3r1ffCZ commented 1 year ago

I got the permisses right, but I also get the occasional fly disappearing when the player teleports to another world. I have everything set to false in eventCommands.yml.

Rexmen1 commented 1 year ago

yea using delay and working fine before the update... nothing changed except the update.

Rexmen1 commented 1 year ago

Ok it doesn't work for me either so the issue Is still from cmi update side...

Rexmen1 commented 1 year ago

disabled the world event commands and still causing world change fly disable issue for players....

Sh3r1ffCZ commented 1 year ago

[17:37:42 WARN]: [CMI] Task #347953 for CMI v9.3.0.6 generated an exception java.lang.IllegalArgumentException: Cannot make player fly if getAllowFlight() is false at org.bukkit.craftbukkit.v1_19_R2.entity.CraftPlayer.setFlying(CraftPlayer.java:2157) ~[purpur-1.19.3.jar:git-Purpur-1895] at com.Zrips.CMI.AllListeners.WorldLimits.lambda$0(WorldLimits.java:90) ~[CMI-9.3.0.6.jar:?] at org.bukkit.craftbukkit.v1_19_R2.scheduler.CraftTask.run(CraftTask.java:101) ~[purpur-1.19.3.jar:git-Purpur-1895] at org.bukkit.craftbukkit.v1_19_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483) ~[purpur-1.19.3.jar:git-Purpur-1895] at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1500) ~[purpur-1.19.3.jar:git-Purpur-1895] at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:482) ~[purpur-1.19.3.jar:git-Purpur-1895] at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1424) ~[purpur-1.19.3.jar:git-Purpur-1895] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1194) ~[purpur-1.19.3.jar:git-Purpur-1895] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:321) ~[purpur-1.19.3.jar:git-Purpur-1895] at java.lang.Thread.run(Thread.java:833) ~[?:?]

Version: 9.3.0.6

EagL3-GIT commented 1 year ago

Yep, its broken in the latest version

Strahilchu commented 4 months ago

Is there a fix for this? Jesus christ!

Strahilchu commented 6 days ago

What about now?