Invsee bug opening inv spontaneous

x1p commented 1 year ago

Description of Issue

Staff member opening some players inventory causes to open this inventory when that player joins or leaves the game.

Ways to reproduce:

staff member executes: /inv Player123
staff member closes inventory
Player123 joins the game
staff member gets to see the inv of Player123 again
staff member closes screen ...after some time....
Player123 leaves the game
staff member gets to see the inv of Player123 again
staff member closes screen

Version Information

CMI: 9.2.6.0 MySQL
CMILib: 1.2.3.7
Server: Purpur 1.19.2-R0.1-SNAPSHOT
CMI economy: Enabled Vault: 1.7.3-b CMI Chat: Enabled
Modules -> 31 enabled 26 disabled: cuffed, mirror, tablist, versionCheck, armorEffects, moneyCheque, noTarget, elytraBoost, eventCommands, coloredArmor, playerCombat, votifier, attachedCommands, spawnerCharge, namePlates, launchPad, armorstand, portals, holograms, dynamicSigns, playerChatTag, flightCharge, disabledEnchants, worldLimitsElytra, ranks, selection

Errors

No errors at that time but I do notice that I have other random errors since last versions.
Perhaps not related but I do want to mention it here, just to make sure I didn't miss anything.

[19:50:32] [Server thread/WARN]: [CMI] Task #931289 for CMI v9.2.6.0 generated an exception
java.lang.ArrayIndexOutOfBoundsException: Index 33 out of bounds for length 27
    at java.util.Arrays$ArrayList.get(Arrays.java:4165) ~[?:?]
    at net.minecraft.core.NonNullList.get(NonNullList.java:44) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at org.bukkit.craftbukkit.v1_19_R1.inventory.CraftInventoryCustom$MinecraftInventory.a(CraftInventoryCustom.java:131) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at org.bukkit.craftbukkit.v1_19_R1.inventory.CraftInventory.getItem(CraftInventory.java:49) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at com.Zrips.CMI.Modules.InvRegEditor.RegChestManager.invClick(RegChestManager.java:358) ~[CMI-9.2.6.0.jar:?]
    at com.Zrips.CMI.Modules.InvRegEditor.RegChestManager.access$2(RegChestManager.java:296) ~[CMI-9.2.6.0.jar:?]
    at com.Zrips.CMI.Modules.InvRegEditor.RegChestManager$1.lambda$0(RegChestManager.java:386) ~[CMI-9.2.6.0.jar:?]
    at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftTask.run(CraftTask.java:101) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1500) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:486) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1424) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1194) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:310) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at java.lang.Thread.run(Thread.java:833) ~[?:?]
[19:50:33] [Server thread/WARN]: [CMI] Task #931301 for CMI v9.2.6.0 generated an exception
java.lang.ArrayIndexOutOfBoundsException: null
[19:50:35] [Server thread/WARN]: [CMI] Task #931332 for CMI v9.2.6.0 generated an exception
java.lang.ArrayIndexOutOfBoundsException: null

and

[17:36:06] [Server thread/WARN]: [CMI] Task #723167 for CMI v9.2.6.0 generated an exception
java.lang.NullPointerException: null
[17:36:06] [Server thread/WARN]: [CMI] Task #723167 for CMI v9.2.6.0 generated an exception
java.lang.NullPointerException: null

and

[12:46:50] [Server thread/WARN]: [CMI] Task #326097 for CMI v9.2.6.0 generated an exception
java.lang.NullPointerException: Cannot invoke "org.bukkit.inventory.ItemStack.clone()" because "<local2>[1]" is null
    at com.Zrips.CMI.Modules.InvRegEditor.RegChestManager.getCraftingInventory(RegChestManager.java:648) ~[CMI-9.2.6.0.jar:?]
    at com.Zrips.CMI.Modules.InvRegEditor.RegChestManager.updateWatcherInventory(RegChestManager.java:266) ~[CMI-9.2.6.0.jar:?]
    at com.Zrips.CMI.Modules.InvRegEditor.RegChestManager.lambda$0(RegChestManager.java:169) ~[CMI-9.2.6.0.jar:?]
    at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftTask.run(CraftTask.java:101) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1500) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:486) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1424) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1194) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:310) ~[purpur-1.19.2.jar:git-Purpur-1857]
    at java.lang.Thread.run(Thread.java:833) ~[?:?]

Relevant Config Sections

No response

Relevant Plugins

No response

Agreements

[X] My server is supported by CMI.
[X] My version of CMI at the time of this report is up to date.
[X] I have searched the github and asked around before making this report.

HamtaBot commented 1 year ago

can confirm the issue

T14D3 commented 1 year ago

Same here, can confirm

Zrips commented 1 year ago

Will issue fix with todays update

Zrips / CMI