CMI makes stats not working

iPymad commented 1 year ago

Description of Issue

This may sound absurd, but this conclusion is based on many tests

When applying the Damage Reduction stat, which reduces incoming damage, to an item through MMOItems, all vanilla damage is effectively mitigated. However, the damage of MythicMobs skills (called from the skill menu) is only mitigated if there is CMI and less than 25 plugins on the server or if there are as many plugins as desired but no CMI on the server.

The tests were done in a rigorous way with several monsters, several skills, removing each plugin one by one. The "Damage Reduction" statistic was set to 100% to prevent any damage. When it was at 100%, I took no vanilla damage but took unmitigated damage from the MM Mobs. I also test multiple versions of CMI for 1.19.2 and same for MythicMobs and MMOItems.

Version Information

[09:31:16 INFO]: --------------------------------------------------
[09:31:16 INFO]: CMI: 9.2.6.1 MySQL-> 9.3.0.6 
[09:31:16 INFO]: CMILib: 1.2.4.1 
[09:31:16 INFO]: Server: Paper(307) 1.19.2-R0.1-SNAPSHOT
[09:31:16 INFO]: CMI economy: Enabled Vault: 1.7.3-CMI(CMIEInjector) CMI Chat: Disabled 
[09:31:16 INFO]: Modules -> 50 enabled 7 disabled: customMessages, tablist, firstJoinMessages, votifier,  headDrop, vanish, playerChatTag
[09:31:16 INFO]: --------------------------------------------------

Errors

No response

Relevant Config Sections

No response

Relevant Plugins

MythicMob 5.2.1 / MMOItems 6.9.1

Agreements

[X] My server is supported by CMI.
[X] My version of CMI at the time of this report is up to date.
[X] I have searched the github and asked around before making this report.

Zrips commented 1 year ago

Amount of plugins will not have any effect on features performance and what it does. This could be an issue with general compatibility issue with one of your plugins doing something with entity damage event which gets modified depending your players permission access you have setup. I'm not that familiar with MMOItems and MM to know exactly how you have your system setup and what's going on in particular in your situation which causes this weird behavior. MM plugin could be applying direct damage to the player without firing damage event or ignoring any modifications done to this event. I will need more information on your DamageControl setup

iPymad commented 1 year ago

After much more testing, it seems that the above "DamageReduction" mechanic (from MythicMob) start to bug when CMI and Jobs or CMI and FastAsyncWorldEdit are on the server. When we have all our plugins including CMI but without Jobs and without FastAsyncWorldEdit, it works. We have tried replacing FAWE with WorldEdit and in this case (Jobs is not present) the bug no longer occurs. Note also that you can have all these plugins at the same time and without CMI, to avoid the bug. Does it helps you ?

Zrips commented 1 year ago

Jobs plugin should not have any impact on damage you cause as its only for data tracking and not controlling things. So it could be caused by FAWE, but then again, its not really a plugin which should have impact on damage event either. I'm not that familiar with DamageReduction in Mythic mods plugin, could you elaborate on your setup, how this thing works and how you tested it out to make it bug out?

iPymad commented 1 year ago

Well, we have tested with only jobs and without FAWE, the bug remains. As well as FAWE without Jobs. When we have both of them but without CMI this do works fine. The DamageReduction stat is a stat that come from MMOItems which is supposed to reduce the damage incoming. To test is I have put the value to 100%. For the MythicMob part, I have taken a basic Mobs from the basic config of MythicMobs and make a skill (called from the skill folder by the mob, file found in mob folder) doing damage. I also test on mobs done by others people and lots of others configurations. The result is that the mitigation 100% attributed by MMOItems stats do works but on one specific case (MythicMob damage from a skill called into the Skill folder of the MM plugin), it does not apply at all.

Zrips / CMI