Zrips / CMI

117 stars 99 forks source link

CMIPlayer events don't inherit from PlayerEvent #7868

Open 456dev opened 1 year ago

456dev commented 1 year ago

Description of Issue

Cmi player events don't inherit from PlayerEvent

This means other plugins that rely on that to provide additional functionality, like discordsrv, which provides #player as a shortcut to get the player referred in the event

affected events

CMIAfkEnterEvent CMIAfkKickEvent CMIAfkLeaveEvent CMIAsyncPlayerTeleportEvent CMIBackpackOpenEvent CMIChunkChangeEvent CMIUserBalanceChangeEvent CMIPvPStartEventAsync CMIPvPEndEventAsync CMIPvEStartEventAsync CMIPvEEndEventAsync CMIPortalCreateEvent CMIPlayerWarnEvent CMIPlayerUnjailEvent CMIPlayerTeleportRequestEvent CMIPlayerTeleportEvent CMIPlayerNickNameChangeEvent CMIPlayerJailEvent CMIPlayerFakeEntityInteractEvent CMIPlayerBanEvent

Version Information

N/A

Correct as of
https://github.com/Zrips/CMI-API/tree/8d60024917df4872cad5362f2a93507667b583aa

Errors

https://discord.com/channels/452792793631555594/526402563847880725/1114258925731192874

An example of discord raising an exception after attempting to use #player, which needs a playerevent

Relevant Config Sections

N/A

Relevant Plugins

DiscordSRV, Any (using CMI's API)

Agreements

mrfloris commented 1 year ago

This! yes plz.