Zrips / CMI

116 stars 97 forks source link

Elevator problem on nether roof #8798

Closed nhanledev closed 4 months ago

nhanledev commented 4 months ago

Description of Issue

After updating to 9.7.2.12, the Elevator sign does not allow players to go upward on any location above nether roof. It still works at a position in overworld and below nether roof.

Edit: The elevetors on the nether roof only works if player is in CREATIVE mode.

My previous version 9.7.0.6 does not have this problem.

Version Information

[11:08:29 INFO]: --------------------------------------------------
[11:08:29 INFO]: CMI: 9.7.2.12 BungeeCord CMIB  MySQL
[11:08:29 INFO]: CMILib: 1.4.7.15 
[11:08:29 INFO]: Server: Paper(496) 1.20.4-R0.1-SNAPSHOT-
[11:08:29 INFO]: CMI economy: Off Vault: 1.7.3-CMI CMI Chat: Off
[11:08:29 INFO]: Modules -> 15 enabled 44 disabled: spawnerProximity, cuffed, customMessages, mirror, tablist, versionCheck, armorEffects, moneyCheque, skin, noTarget, elytraBoost, cmiPlaytime, elytraLaunch, bossBarCompass, coloredArmor, chatBubble, playerCombat, votifier, headDrop, attachedCommands, spawnerCharge, interactiveCommands, namePlates, timedCommands, homeInteractions, hpBossBar, launchPad, armorstand, portals, anvilRenameColor, jail, spawners, paintingEditor, dynamicSigns, playerChatTag, durabilityLoss, flightCharge, disabledEnchants, ranks, firstJoinMessages, selection, silentChest, warmup, totemBehavior
[11:08:29 INFO]: --------------------------------------------------

Errors

No response

Relevant Config Sections

No response

Relevant Plugins

No response

Agreements

CloudeLecaw commented 4 months ago

have you checked you havent enabled netherRoof protection on you server or adjust nether roof high?

nhanledev commented 4 months ago

have you checked you havent enabled netherRoof protection on you server or adjust nether roof high?

No, the Elevator works in older version. I double checked the settings that you've mentioned and it looks good to me

  # Will teleport players down from nether 'roof'
  PreventPlayersOnNetherRoof: false
  # Will define nether roof height. Keeping it at 0 will use default nether height, which is 128
  netherRoofHeight: 0
  # This will teleport players up from beneath bedrock, if they ave flying or gliding with the elytra on.
  PreventPlayersBelowBedrock: true
Zrips commented 4 months ago

Retested elevators usage, and everything looks to be working correctly with regular players. By any chance there is another plugin interfering and preventing players teleportations?

nhanledev commented 4 months ago

Retested elevators usage, and everything looks to be working correctly with regular players. By any chance there is another plugin interfering and preventing players teleportations?

I tested the elevator in multiple scenerios:

nhanledev commented 4 months ago

Retested elevators usage, and everything looks to be working correctly with regular players. By any chance there is another plugin interfering and preventing players teleportations?

I tested the elevator in multiple scenerios:

  • In the overworld, survival mode: Work, Bothways
  • In the nether, survival mode, below nether roof: Work, Bothways
  • In the nether, survival mode, above nether roof: Work partially, downward only
  • In the nether, CREATIVE mode, above nether roof: Work, Bothways

I attach a video record that shows:

The video:

https://github.com/Zrips/CMI/assets/28459250/f1997590-83d4-4cf6-aa88-1b57c3e5caf1

CloudeLecaw commented 4 months ago

can you try to make the Plattform in the air two rows of wood deep instead of one row wood only and recheck if the issue still remains?

i renember there was some changings with teleportations. might this happens too in this case if its above the netherroof...

Zrips commented 4 months ago

@nhanledev Could you test it without any other plugin to rule out 3rd party interference?

nhanledev commented 4 months ago

Hello, the test above is a fresh server with only CMI and CMILib. I will test it again with more than two rows of platform.

nhanledev commented 4 months ago

I attach a video record that has a 2-layer platform instead of one the eliminate the teleportation changes that CloudeLecaw has mentioned before. The issue is still persist.

The test server has only 2 plugins: CMI and CMILib, as shown in the beginning of the clip.

https://github.com/Zrips/CMI/assets/28459250/ef94bdfc-d340-4ecc-a013-28e3a1942467

CloudeLecaw commented 4 months ago

@nhanledev Could you test it without any other plugin to rule out 3rd party interference?

@Zrips - he showed in his video he is using no other plugins. just cmilib and cmi.

CloudeLecaw commented 4 months ago

would you mind showing use your netherRoof setting?

nhanledev commented 4 months ago

would you mind showing use your netherRoof setting?

Hello, that was the fresh server with default CMI settings, which has these in the config.yml file:

  # Will teleport players down from nether 'roof'
  PreventPlayersOnNetherRoof: false
  # Will define nether roof height. Keeping it at 0 will use default nether height, which is 128
  netherRoofHeight: 0
  # This will teleport players up from beneath bedrock, if they ave flying or gliding with the elytra on.
  PreventPlayersBelowBedrock: false
Zrips commented 4 months ago

@nhanledev Ok, thanks for info, reproduced issue now. Will make a fix with next version.