Applying enchants to Mace through /enchant applies wrong enchants

MaHl111 commented 4 months ago

Description of Issue

As stated in title, trying to enchant mace through /enchant applies wrong enchants to the mace. Lore shows these enchants:

density -> swift_sneak
breach -> thorns
wind_burst -> unbreaking

/iteminfo shows the correct enchants, however, their mechanics are not applied. They can, however be applied using enchanted_book like Density 5. Applying Density 5 in that way, results in Protection_environmental -> 5 in /iteminfo, enchant works: obrázok Reversing the process and trying to apply /enchant Protectionenvironmental to the item results in Protection 1 and:

Version Information

CMI: 9.7.4.4 SqLite
CMILib: 1.5.0.2 -> 1.5.0.5
Server: Paper(44) 1.21-R0.1-SNAPSHOT+
CMI economy: Disabled CMIChat: Disabled
Modules -> 65 enabled 1 disabled: votifier

Errors

No response

Relevant Config Sections

No response

Relevant Plugins

No response

Agreements

[X] My server is supported by CMI.
[X] My version of CMI at the time of this report is up to date.
[X] I have searched the github and asked around before making this report.

Rexmen1 commented 4 months ago

looks like enchants were not updated correctly for 1.21

Rexmen1 commented 4 months ago

same issue on my server..

MaHl111 commented 4 months ago

looks like enchants were not updated correctly for 1.21

Neither was /disableenchants, but I think it was of minor importance, so it would be eventually fixed

VISION6969 commented 3 months ago

I agree, enchants are not updated for 1.21 properly

MaHl111 commented 3 months ago

Update: As of CMILib 1.5.0.6 (Thanks @CloudeLecaw for pointing out the version in separate issue) /enchant applies proper enchants to the Mace and they work correctly. There is still minor bug with /iteminfo and incorrect text of the applied enchant, example for Density: obrázok

These however, are separate issues.

CloudeLecaw commented 3 months ago

looks like enchants were not updated correctly for 1.21

jup new weapon, new enchants. correct.

currently cmi was made to run on 1.21, that doesnt mean it added all its new stuff.

oh and yes the iteminfo shows wrong enchant names.. wasnt that fixed?

MaHl111 commented 3 months ago

looks like enchants were not updated correctly for 1.21

jup new weapon, new enchants. correct.

currently cmi was made to run on 1.21, that doesnt mean it added all its new stuff.

oh and yes the iteminfo shows wrong enchant names.. wasnt that fixed?

Nope, or at least, it wasn't in public release (at the time of testing, latest version for CMI was 9.7.4.4 and CMILib was 1.5.0.6), I've updated CMILib to the latest version which fixed enchant applying and mechanics, but the image taken was with the latest version. So iteminfo just shows different enchant but it's still incorrect. They are however synced with enchant because they show the same name when applying.

Zrips / CMI