/nick Does Not Obey the CMI Color Permissions When Using Hex Colors

Mikirae commented 4 months ago

Description of Issue

/nick does not properly obey the coloring permissions when using hex colors. If you use a hex color, even with the cmi.command.colors.* set to false. I'll include screenshots showing it to be bugged with &# hex colors, as well as the standard CMI {#} hex colors. I'll also show that it does properly block Default Minecraft Color Codes .

Version Information

[22:38:28] [Server thread/INFO] [Console/]: CMI: 9.7.4.5 SqLite
[22:38:28] [Server thread/INFO] [Console/]: CMILib: 1.5.0.7
[22:38:28] [Server thread/INFO] [Console/]: Server: Arclight 1.16.5-R0.1-SNAPSHOT+
[22:38:28] [Server thread/INFO] [Console/]: CMI economy: Enabled Vault: 1.7.3-CMI CMI Chat: Enabled
[22:38:28] [Server thread/INFO] [Console/]: Modules -> 45 enabled 21 disabled: spawnerProximity, cuffed, hpBossBar, tablist, armorstand, moneyCheque, afk, skin, spawners, kits, bossBarCompass, ranks, playerCombat, votifier, headDrop, spawnerCharge, silentChest, warmup, vanish, homeInteractions, totemBehavior

Errors

No response

Relevant Config Sections

No response

Relevant Plugins

No response

Agreements

[X] My server is supported by CMI.
[X] My version of CMI at the time of this report is up to date.
[X] I have searched the github and asked around before making this report.

CloudeLecaw commented 4 months ago

cmi.command.colors.* is wrong.

take a look in Chat.yml at the #notes of color management. Its cmi.colors.nickname.[colorName] so in case of given a star permission to allow all colore and formats use cmi.colors.nickname.*

cmi.command.colors is just the permission for the colorcheck command /cmi colors

Mikirae commented 4 months ago

I apparently stated it incorrectly in my description, but I provided screenshots showing the actual permission node of cmi.colors.nickname.red being false, yet still allowing it to go through.

On Wed, Jul 31, 2024, 11:00 PM CloudeLecaw @.***> wrote:

cmi.command.color is wrong.

take a look in Chat.yml

its

cmi.colors.nickname.[colorName]

— Reply to this email directly, view it on GitHub https://github.com/Zrips/CMI/issues/8933#issuecomment-2261951716, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6FLZOYPOCEPEOQIJUNR2LZPGXFTAVCNFSM6AAAAABKZVS772VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRRHE2TCNZRGY . You are receiving this because you authored the thread.Message ID: @.***>

CloudeLecaw commented 4 months ago

red = &c darkred = &4

looking at the word "disabled" this is shown in red.

you changed it in your Screenshot to a darked not a red..

so negating of red only would make nothing if you choose darkred as color.

here the list from chat.yml

 # Colors:
black(&0)
darkblue(&1)
darkgreen(&2)
darkaqua(&3)
darkred(&4)
darkpurple(&5)
gold(&6)
gray(&7)
darkgray(&8)
blue(&9)
green(&a)
aqua(&b)
red(&c)
lightpurple(&d)
yellow(&e)
white(&f)
magic(&k)
bold(&l)
strikethrough(&m)
underline(&n)
italic(&o)
reset(&r)

for hex colors.. its a bit tricky they have so much permission because hex has so many colors.

so basicly if you forbit a single hex they can still use it by just chabgeing a colorcode by one number.

so if you wabt to forbit Single hex colors it might be the best just to allow single selected colors.

so might negate cmi.colors.nickname.hex

Mikirae commented 3 months ago

I have quite literally shown the exact steps causing the issue in this ticket. You can test it for yourself, and it will work. I have tested it on live servers and test servers with a fresh setup. It works every single time.

On Thu, Aug 1, 2024, 5:20 AM CloudeLecaw @.***> wrote:

red = &c darkred = &4

you changed it in your Screenshot toba darkred not a red..

— Reply to this email directly, view it on GitHub https://github.com/Zrips/CMI/issues/8933#issuecomment-2262682061, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6FLZKKG6B6FYGCFGZFS5DZPIDVTAVCNFSM6AAAAABKZVS772VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRSGY4DEMBWGE . You are receiving this because you authored the thread.Message ID: @.***>

github-actions[bot] commented 2 weeks ago

This issue has been marked as stale due to inactivity.

Zrips / CMI