search

Zrips / CMI

117 stars 99 forks source link

Mirror Issues/Crash #9289

Open mercurialmusic opened 2 weeks ago

mercurialmusic commented 2 weeks ago

Description of Issue

We've stumbled on some pretty significant mirror issues in recent builds - unsure when they started but we use mirror pretty regularly so I'm guessing fairly recent. Mostly related to slabs -- in survival placing 3 slabs will remove 3 stacks of slabs from the survival inventory, but places the blocks correctly. Breaking these drops the correct number of blocks, but then you're out the extra stacks.

In creative it's much worse -- placing the slabs just flat out crashes the server.

Strangely, no errors in console.

Version Information

CMI plugin version: 9.7.7.8 Velocity CMIB  SqLite
CMILib: 1.5.2.2 
Server: Paper(128) 1.21.1-R0.1-SNAPSHOT-
CMI economy: Enabled Vault: 1.7.3-CMI CMI Chat: Disabled 
Modules -> 65 enabled 2 disabled: ranks, skin

Errors

No response

Relevant Config Sections

No response

Relevant Plugins

No response

Agreements

mercurialmusic commented 2 weeks ago

With additional testing, seems to be mostly related to placing a slab on another slab to create a double slab.

Zrips commented 2 weeks ago

How many slabs are you placing at once to get server into that crash state? As tested out with all mirror modes enabled at once and no issues with placing those blocks. Can you specify slab type or does it happen with any type? Just FYI there is Mirror V2 in the works which will have completely reworked code and handling and general feature set, but it would be nice to figure out what caused this issue for you to not have it in the new system.

mercurialmusic commented 2 weeks ago

We didn't test all wood types, but tested multiple including at least spruce, birch, and oak. Tested with just one axis (X), 2 axis (X & Z), and 4 axis (X, Z, XZ, & ZX), all doing the same thing. Same results on all of our servers as well, so it wasn't limited to a single instance. It does seem to be limited to placing a slab on top or bottom of an existing slab to complete the double-slab block.

In case it's useful, here's the thread dump: https://gist.github.com/mercurialmusic/284ea6f564a953b5a722549bd0bd2c95

Zrips commented 1 week ago

Retested with your exact minecraft server and included Jobs plugin in to the mix as your thread dump mentioned it. No issues while placing slabs, single or double. Could you test this without any other plugins except CMI?