Zrips / Jobs

Jobs
Apache License 2.0
177 stars 215 forks source link

Jobs toplist working with Holograpics display (Holographic scoreboard) #1593

Open OfficialAndyX opened 1 year ago

OfficialAndyX commented 1 year ago

a small step towards holographic scoreboard (HS) compatibility?

Basically you can add /balltop to holographic scoreboard and it simply outputs the top 10 people from (essentialsx) baltop (HS has a timer update setting dw)

(on updating spigotmc compatibility to HS page i recommend you would place (Update config to not use scoreboard output for /toplist)) so all we need to do is add /jobs top to be allowed from console At this moment it seems the command is not allowed thru console but it does give an output of commands in a list that you can do inside of console.

(Sadly enough HS is out of date but they did have a PLAYER | CONSOLE option, only console option works player not anymore. idk what is and isnt allowed but if you were to (update/fix) the player part of this plugin. This would also make everything work perfectly fine, perhaps even allow /Jobs stats aswell because currently that doesnt work since the console can't output everyones stats seperately depending on who sees the hologram unless the HS plugin on update adds player name %player% placeholder for commands)

Thanks for reading if i was not clear enough or not using proper words (sorry in advance) feel free to contact me on discord AndyIsHere#0906

Thank you! Andy

Zrips commented 1 year ago

I can add support for console while performing /jobs top command, it was mainly limited due to it outputting into scorebar but its basic code update to support console, honestly don't even know why it was made in this limited way. And to be fair, we do have placeholders which produce same results: %jobsr_jtop_name_brewer_1% %jobsr_jtop_level_brewer_1% Don't know about stats command tho, its made to output yours or target player jobs statistics, while there might be some issue with trying to display progress bar in console, which I can fix, duno what else can be improved here exactly for it to be more compatible with HS. Side note is that I have no experience with this plugin, so can't comment much on how and what should be changed for best compatibility, so any additional information is appreciated