Zrips / Jobs

Jobs
Apache License 2.0
185 stars 216 forks source link

Several bugs in latest version 4.15.6 (gtop/workers set to 0/ and armor_stand/item_frame) #716

Closed RSLuke closed 4 years ago

RSLuke commented 4 years ago

*Description of issues:

  1. gtop now displays the list but only the first page, no errors
  2. Workers are still set to 0 I'm using 10.1.44 (10.1.44-MariaDB-0+deb9u1)
  3. armor_stand and item_frame are using cob_web and spruce_leaves translation, so I had to remove them since it confuses players (cob web and spruce leaves cannot be crafted and they couldn't know there were in fact armor stands and item frames)
  4. Players don't always recieve experience when feeding/breeding animals.
  5. Happens now from the beginning : Often players have in the bossbar the exp displayed for their previous action. Example : Player mines diamond ore but he mined a coal ore just before, he will see in the bossbar the exp from the coal ore (no problems regarding the exp recieved)
  6. Taming animals don't give exp anymore

Just so you know (I'm not a beginner), I'm running a french server with 300+ players online and thousands of active players, I'm running my network for 2 years now and I added Jobs again in September 2019.

Congratulations for the hard work on the plugin, it may have bugs but they add a real value to rp servers.


Jobs 4.15.6

Server Type (Spigot/Paperspigot/etc): Paperspigot 1.13.2

RSLuke commented 4 years ago

Update with Jobs Jobs4.15.7 1. Now /jobs browse is completely broken, the gui won't open

  1. The /jobs gtop starts at 2nd place : https://puu.sh/FswwX/aaaa651743.png
  2. The /jobs limit won't show the placeholders : https://puu.sh/FswxM/db5b10ea2a.png Same for the message sent to the player when he reaches the limit.
  3. Players still don't recieve exp from taming animals.
  4. Some players cannot be seen in the toplist with /jobs top job
montlikadani commented 4 years ago

Can you please show your generalConfig, jobConfig and full server log? You can compress to a ZIP file.

RSLuke commented 4 years ago

Can I give it to you in private ?

montlikadani commented 4 years ago

Now GUIs got fixed, commit

montlikadani commented 4 years ago

Now taming animals works, https://github.com/Zrips/Jobs/commit/2113e3441cea92c1b0c912c355287bd20fbb876e

montlikadani commented 4 years ago

Is these issues still reproduce in latest version? If something still not, then list out here.

RSLuke commented 4 years ago

Yes I'll make you a list (I'm Luke on Discord who pmed you)

Major issue :

  1. On a restart, if a player had completed his quest before the restart, he will be able to claim the rewards by doing one single action out of 120 per example. The quest is still shown as completed on the restart but he can anyway activate the commands. Steps to reproduce : → I'm a woodcutter, I have a quest, I accomplish it : https://puu.sh/FHoqa/398b25dc0b.png https://puu.sh/FHotl/d6b31b6d50.png → As an Admin I restart the server, I reconnect as player and do /jobs quests : https://puu.sh/FHovj/751665d507.png → I cut only one oak_wood out of 1728 and obtain immediately the rewards again : https://puu.sh/FHowF/7aa3b643b2.png

Significative issues :

  1. Happens now from the beginning : Often players have in the bossbar the exp displayed for their previous action. Example : Player mines diamond ore but he mined a coal ore just before, he will see in the bossbar the exp from the coal ore (no problems regarding the exp recieved) → still not fixed
  2. On my first connection of the day, the first action I do I don't get paid and I have the message in the action bar from the limits : &eTime left until Exp limit resets: &2%time%
  3. Lots of player can't find themselves in /jobs top [job], some datas are missing in the top Edit : Here is an example, there is a whole between 1st page and 2nd page : https://puu.sh/FHrWs/c233aa99ab.png https://puu.sh/FHrX3/78a91b6cd2.png https://puu.sh/FHrXo/b912cb28e5.png

Minor issues :

  1. On gtop, the first number shown is a 2, not a 1 (but the good username is shown) https://puu.sh/FHokW/a13906fb27.png

Unsure if it is fixed or not : Happens now from the beginning : Often players have in the bossbar the exp displayed for their previous action. Example : Player mines diamond ore but he mined a coal ore just before, he will see in the bossbar the exp from the coal ore (no problems regarding the exp recieved)

montlikadani commented 4 years ago

Fixed gtop counting https://github.com/Zrips/Jobs/commit/72d93657e75a6e1a1bc63b002ff27dcb7be40eb8

Zrips commented 4 years ago

If any of the issues persists with next update, please let us know. And please create one ticket for each issue you encounter for simpler tracking what was solved and what was not.