Zrips / Jobs

Jobs
Apache License 2.0
177 stars 215 forks source link

/jobs gtop with incorrect arguments shows wrong message. #977

Closed SirKillian closed 3 years ago

SirKillian commented 3 years ago

Plugin version: 4.16.2 Description of issue: using "/jobs gtop" with incorrect arguments (/jobs gtop 5 test) shows the "command.gtop.help.info' message instead of what I assume should be "command.help.output.cmdUsage".

The command "/jobs top miner 5 test" (which is also invalid usage, gives different results than the command above).

Using /jobs gtop with wrong arguments: jobs-report4

mrfloris commented 3 years ago

Can confirm, while this isn't really super important to operate, it is annoying and we've run into this in the past. We kept thinking we could display for example gtop 5 mining, but of course.. that'd be silly. It would be nice if it's not expected syntax that it can tell us how to use the command or ignore what comes after if there's no further vars.

> ver Jobs
[13:07:17 INFO]: Jobs version 4.16.3
[13:07:17 INFO]: Jobs Plugin for the BukkitAPI
[13:07:17 INFO]: Website: https://www.spigotmc.org/resources/4216/
[13:07:17 INFO]: Authors: phrstbrn, Zrips and montlikadani
> ver
[13:07:18 INFO]: This server is running Paper version git-Paper-246 (MC: 1.16.3) (Implementing API version 1.16.3-R0.1-SNAPSHOT)
[13:07:18 INFO]: Previous version: git-Paper-245 (MC: 1.16.3)
[13:07:18 INFO]: You are running the latest version
>
Screenshot 2020-10-24 at 13 06 59

Secondly, from console, it should either let us know it's an ingame command or show us how to use it, or output the correct information. For example:

> jobs gtop
[13:09:05 INFO]: ------- ======= Jobs ======= -------
[13:09:05 INFO]: /Jobs join [jobname] - Join the selected job.
[13:09:05 INFO]: /Jobs itembonus  - Check item bonus
[13:09:05 INFO]: /Jobs browse  - List the jobs available to you.
[13:09:05 INFO]: /Jobs info [jobname] [action] - Show how much each job is getting paid and for what.
[13:09:05 INFO]: /Jobs bonus [jobname] - Show job bonuses
[13:09:05 INFO]: /Jobs area add/remove/info/list - Modify restricted areas.
[13:09:05 INFO]: /Jobs stats [playername] - Show the level you are in each job you are part of.
> jobs gtop 1
[13:09:11 INFO]: ------- ======= Jobs ======= -------
[13:09:11 INFO]: /Jobs join [jobname] - Join the selected job.
[13:09:11 INFO]: /Jobs itembonus  - Check item bonus
[13:09:11 INFO]: /Jobs browse  - List the jobs available to you.
[13:09:11 INFO]: /Jobs info [jobname] [action] - Show how much each job is getting paid and for what.
[13:09:11 INFO]: /Jobs bonus [jobname] - Show job bonuses
[13:09:11 INFO]: /Jobs area add/remove/info/list - Modify restricted areas.
[13:09:11 INFO]: /Jobs stats [playername] - Show the level you are in each job you are part of.
> jobs gtop 5 mining
[13:09:15 INFO]: Shows top %amount% players by global jobs level.
>
mrfloris commented 3 years ago

Thank you mont for fixing this.