search

Zsailer / nx_altair

Draw interactive NetworkX graphs with Altair
MIT License
224 stars 26 forks source link

Develop #10

Closed ryanpeach closed 6 years ago

ryanpeach commented 6 years ago

This contains the merge of my other two pull requests along with the bug fix for the issue I recently submitted.

Zsailer commented 6 years ago

For reference... This combines PR's #7 and #8.

Zsailer commented 6 years ago

This looks good. Thank you for making the changes to the argument names.

As an aside, the newest release of networkx uses actual arrows for directed graphs (no longer using the rectangles). I don't think Vega has arrows just yet--so we may add that in the future.

That said, I think this PR looks good. I'm going to merge it and release a new version of nx_altair in the next few days.

Thanks @ryanpeach!

ryanpeach commented 6 years ago

Arrows would be possible with decent ease if you wanted them, as they are just lines with fixed length offset by an angle and mirrored along the edge. But it would double the number of graphical elements which I don't think is wise.

ryanpeach commented 6 years ago

Glad you liked it!